Summary: | [EFL] EFL's LayoutTestController needs removeAllVisitedLinks implementation | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mikhail Pozdnyakov <mikhail.pozdnyakov> | ||||||
Component: | WebKit EFL | Assignee: | Mikhail Pozdnyakov <mikhail.pozdnyakov> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | gyuyoung.kim, gyuyoung.kim, lucas.de.marchi, rakuco, sw0524.lee, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | 82579 | ||||||||
Bug Blocks: | |||||||||
Attachments: |
|
Description
Mikhail Pozdnyakov
2012-03-30 05:13:46 PDT
Created attachment 134796 [details]
fix: implementation of LayoutTestController::removeAllVisitedLinks() method
Comment on attachment 134796 [details]
fix: implementation of LayoutTestController::removeAllVisitedLinks() method
Even though a patch is simple, I like to add simple description to patch personally. But, it looks this patch is clear. LGTM.
(In reply to comment #2) > (From update of attachment 134796 [details]) > Even though a patch is simple, I like to add simple description to patch personally. But, it looks this patch is clear. LGTM. Added a short description of the fix. Comment on attachment 134796 [details]
fix: implementation of LayoutTestController::removeAllVisitedLinks() method
Looks good.
Comment on attachment 134796 [details]
fix: implementation of LayoutTestController::removeAllVisitedLinks() method
Looks good to me too.
It looks you need to rebase this patch. Then, please find reviewer on irc. Created attachment 156658 [details]
rebased
Comment on attachment 156658 [details]
rebased
rs=me.
Comment on attachment 156658 [details] rebased Clearing flags on attachment: 156658 Committed r124756: <http://trac.webkit.org/changeset/124756> All reviewed patches have been landed. Closing bug. |