Bug 82721

Summary: [BlackBerry] Upstream local change of PlatformKeyboardEventBlackBerry.cpp
Product: WebKit Reporter: Charles Wei <charles.wei>
Component: WebKit BlackBerryAssignee: Charles Wei <charles.wei>
Status: RESOLVED FIXED    
Severity: Normal CC: leo.yang, rwlbuis, staikos, tonikitoo, webkit.review.bot, xuewen.ok
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch v1
none
Patch none

Charles Wei
Reported 2012-03-30 04:57:00 PDT
PlatformKeyboardEventBlackBerry.cpp needs to be upstreamed of the following changes: 1. Now the PlatformKeyboardEvent needs a timestamp. 2. Fix the initialization sequence. 3. BackTab as Sift + Tab.
Attachments
Patch v1 (3.41 KB, patch)
2012-03-30 05:25 PDT, Charles Wei 		no flags
DetailsFormatted DiffDiff
Patch (2.83 KB, patch)
2012-03-30 23:19 PDT, Charles Wei 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Charles Wei
Comment 1 2012-03-30 05:25:31 PDT
Created attachment 134790 [details] Patch v1
WebKit Review Bot
Comment 2 2012-03-30 05:28:35 PDT
Attachment 134790 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/platform/blackberry/PlatformKeyboardEventBlackBerry.cpp:28: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Charles Wei
Comment 3 2012-03-30 23:19:33 PDT
Created attachment 134946 [details] Patch
Rob Buis
Comment 4 2012-03-31 05:21:32 PDT
Comment on attachment 134946 [details] Patch Looks good.
Charles Wei
Comment 5 2012-03-31 05:26:10 PDT
Comment on attachment 134946 [details] Patch Thanks for the review, Rob.
WebKit Review Bot
Comment 6 2012-03-31 05:33:17 PDT
Comment on attachment 134946 [details] Patch Clearing flags on attachment: 134946 Committed r112789: <http://trac.webkit.org/changeset/112789>
WebKit Review Bot
Comment 7 2012-03-31 05:33:22 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.