Bug 82706

Summary: Need using namespace std for system calls in MIMESniffing.cpp
Product: WebKit Reporter: Charles Wei <charles.wei>
Component: WebKit BlackBerryAssignee: Charles Wei <charles.wei>
Status: RESOLVED FIXED    
Severity: Normal CC: rwlbuis, staikos, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Charles Wei
Reported 2012-03-30 02:08:16 PDT
Source/WebCore/platform/network/MIMESniffing.cpp uses many libc calls like memcmp, strcmp, etc, directly without a namespace, and that fails compilation for some compilers, like BlackBerry porting. Need using namespace std to get through.
Attachments
Patch (1.61 KB, patch)
2012-03-30 02:18 PDT, Charles Wei 		no flags
DetailsFormatted DiffDiff
Patch (1.26 KB, patch)
2012-04-04 18:14 PDT, Charles Wei 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Charles Wei
Comment 1 2012-03-30 02:18:29 PDT
Created attachment 134750 [details] Patch strcmp and memcmp are c library APIs and should be in std namespace.
Antonio Gomes
Comment 2 2012-04-03 20:37:39 PDT
please adjust the new bug title in the changelog before landing...
Charles Wei
Comment 3 2012-04-04 18:14:28 PDT
Created attachment 135736 [details] Patch
Charles Wei
Comment 4 2012-04-04 18:18:33 PDT
Comment on attachment 135736 [details] Patch Thanks for the review, Antonio.
WebKit Review Bot
Comment 5 2012-04-04 20:43:39 PDT
Comment on attachment 135736 [details] Patch Clearing flags on attachment: 135736 Committed r113283: <http://trac.webkit.org/changeset/113283>
WebKit Review Bot
Comment 6 2012-04-04 20:43:43 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.