Bug 82695

Summary: [BlackBerry] Add local: protocol support in KURL for blackberry
Product: WebKit Reporter: Leo Yang <leo.yang>
Component: WebKit BlackBerryAssignee: Leo Yang <leo.yang>
Status: RESOLVED FIXED    
Severity: Normal CC: charles.wei, rwlbuis, staikos, tonikitoo, webkit.review.bot, zimmermann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 73144    
Attachments:
Description Flags
Patch none

Leo Yang
Reported 2012-03-29 23:25:33 PDT
BlackBerry porting is using local: protocol just as file: protocol with the exception that it sandboxes the path to the application private space.
Attachments
Patch (2.95 KB, patch)
2012-03-29 23:29 PDT, Leo Yang 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Leo Yang
Comment 1 2012-03-29 23:29:43 PDT
Created attachment 134731 [details] Patch
Rob Buis
Comment 2 2012-04-03 13:12:08 PDT
Comment on attachment 134731 [details] Patch The code change looks ok. Please make sure we really use this code before cq+.
Leo Yang
Comment 3 2012-04-04 20:35:39 PDT
(In reply to comment #2) > (From update of attachment 134731 [details]) > The code change looks ok. Please make sure we really use this code before cq+. Thanks for your review. We are using KURL::parse() for local:/// urls and we can reach the patched code chunk in KURL::parse(). I don't find a case to reach portAllowed() for both file:/// and local:///. But because there is checking of file:/// protocol in portAllowed(), we should add checking of local:/// since local:/// is same as file:/// here.
Leo Yang
Comment 4 2012-04-04 20:36:13 PDT
Comment on attachment 134731 [details] Patch Sending to cq ...
WebKit Review Bot
Comment 5 2012-04-04 21:06:46 PDT
Comment on attachment 134731 [details] Patch Clearing flags on attachment: 134731 Committed r113285: <http://trac.webkit.org/changeset/113285>
WebKit Review Bot
Comment 6 2012-04-04 21:06:51 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.