Summary: | [BlackBerry] Add local: protocol support in KURL for blackberry | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Leo Yang <leo.yang> | ||||
Component: | WebKit BlackBerry | Assignee: | Leo Yang <leo.yang> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | charles.wei, rwlbuis, staikos, tonikitoo, webkit.review.bot, zimmermann | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 73144 | ||||||
Attachments: |
|
Description
Leo Yang
2012-03-29 23:25:33 PDT
Created attachment 134731 [details]
Patch
Comment on attachment 134731 [details]
Patch
The code change looks ok. Please make sure we really use this code before cq+.
(In reply to comment #2) > (From update of attachment 134731 [details]) > The code change looks ok. Please make sure we really use this code before cq+. Thanks for your review. We are using KURL::parse() for local:/// urls and we can reach the patched code chunk in KURL::parse(). I don't find a case to reach portAllowed() for both file:/// and local:///. But because there is checking of file:/// protocol in portAllowed(), we should add checking of local:/// since local:/// is same as file:/// here. Comment on attachment 134731 [details]
Patch
Sending to cq ...
Comment on attachment 134731 [details] Patch Clearing flags on attachment: 134731 Committed r113285: <http://trac.webkit.org/changeset/113285> All reviewed patches have been landed. Closing bug. |