Bug 82663

Summary:

[chromium] Update paths in GYP files

Product:

WebKit

Reporter:

Ryan Sleevi <rsleevi>

Component:

New Bugs

Assignee:

Ryan Sleevi <rsleevi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none

Ryan Sleevi

Reported 2012-03-29 14:50:07 PDT

[chromium] Update paths in GYP files

Attachments
Patch (4.49 KB, patch) 2012-03-29 14:52 PDT, Ryan Sleevi	no flags	Details Formatted Diff Diff
Patch (4.45 KB, patch) 2012-03-29 15:01 PDT, Ryan Sleevi	no flags	Details Formatted Diff Diff
Patch (1.20 KB, patch) 2012-03-29 15:29 PDT, Ryan Sleevi	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Ryan Sleevi

Comment 1 2012-03-29 14:52:31 PDT

Created attachment 134671 [details] Patch

WebKit Review Bot

Comment 2 2012-03-29 14:57:29 PDT

Attachment 134671 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.

Ryan Sleevi

Comment 3 2012-03-29 15:01:41 PDT

Created attachment 134675 [details] Patch

Adam Barth

Comment 4 2012-03-29 15:26:18 PDT

Comment on attachment 134675 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=134675&action=review I'm actually working on a patch that touches these same lines. Hopefully ti will land soon. > Source/WebCore/WebCore.gypi:-4608 > - 'plugins/gtk/PluginDataGtk.cpp', This part isn't in my change, so you still might want to do this part.

Ryan Sleevi

Comment 5 2012-03-29 15:29:32 PDT

Created attachment 134684 [details] Patch

Adam Barth

Comment 6 2012-03-29 15:31:13 PDT

Comment on attachment 134684 [details] Patch Thanks.

WebKit Review Bot

Comment 7 2012-03-29 15:36:31 PDT

Comment on attachment 134684 [details] Patch Rejecting attachment 134684 [details] from commit-queue. rsleevi@chromium.org does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights.

Adam Barth

Comment 8 2012-03-29 17:04:04 PDT

Comment on attachment 134684 [details] Patch For the record, https://bugs.webkit.org/show_bug.cgi?id=82677 is the patch that has the other parts of this change.

WebKit Review Bot

Comment 9 2012-03-29 18:16:13 PDT

Comment on attachment 134684 [details] Patch Clearing flags on attachment: 134684 Committed r112628: <http://trac.webkit.org/changeset/112628>

WebKit Review Bot

Comment 10 2012-03-29 18:16:17 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.