Bug 82663 - [chromium] Update paths in GYP files
Summary: [chromium] Update paths in GYP files
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryan Sleevi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-29 14:50 PDT by Ryan Sleevi
Modified: 2012-03-29 18:16 PDT (History)
1 user (show)

See Also:

Attachments
Patch (4.49 KB, patch)
2012-03-29 14:52 PDT, Ryan Sleevi 		no flags Details | Formatted Diff | Diff
Patch (4.45 KB, patch)
2012-03-29 15:01 PDT, Ryan Sleevi 		no flags Details | Formatted Diff | Diff
Patch (1.20 KB, patch)
2012-03-29 15:29 PDT, Ryan Sleevi 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Sleevi 2012-03-29 14:50:07 PDT 
[chromium] Update paths in GYP files
Comment 1 Ryan Sleevi 2012-03-29 14:52:31 PDT 
Created attachment 134671 [details]
Patch
Comment 2 WebKit Review Bot 2012-03-29 14:57:29 PDT 
Attachment 134671 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Ryan Sleevi 2012-03-29 15:01:41 PDT 
Created attachment 134675 [details]
Patch
Comment 4 Adam Barth 2012-03-29 15:26:18 PDT 
Comment on attachment 134675 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=134675&action=review

I'm actually working on a patch that touches these same lines.  Hopefully ti will land soon.

> Source/WebCore/WebCore.gypi:-4608
> -            'plugins/gtk/PluginDataGtk.cpp',

This part isn't in my change, so you still might want to do this part.
Comment 5 Ryan Sleevi 2012-03-29 15:29:32 PDT 
Created attachment 134684 [details]
Patch
Comment 6 Adam Barth 2012-03-29 15:31:13 PDT 
Comment on attachment 134684 [details]
Patch

Thanks.
Comment 7 WebKit Review Bot 2012-03-29 15:36:31 PDT 
Comment on attachment 134684 [details]
Patch

Rejecting attachment 134684 [details] from commit-queue.

rsleevi@chromium.org does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.
Comment 8 Adam Barth 2012-03-29 17:04:04 PDT 
Comment on attachment 134684 [details]
Patch

For the record, https://bugs.webkit.org/show_bug.cgi?id=82677 is the patch that has the other parts of this change.
Comment 9 WebKit Review Bot 2012-03-29 18:16:13 PDT 
Comment on attachment 134684 [details]
Patch

Clearing flags on attachment: 134684

Committed r112628: <http://trac.webkit.org/changeset/112628>
Comment 10 WebKit Review Bot 2012-03-29 18:16:17 PDT 
All reviewed patches have been landed.  Closing bug.