Bug 82663 – [chromium] Update paths in GYP files

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Ryan Sleevi]

[chromium] Update paths in GYP files

[Ryan Sleevi]

Created attachment 134671 [details]
Patch

[WebKit Review Bot]

Attachment 134671 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Ryan Sleevi]

Created attachment 134675 [details]
Patch

[Adam Barth]

Comment on attachment 134675 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=134675&action=review

I'm actually working on a patch that touches these same lines.  Hopefully ti will land soon.

> Source/WebCore/WebCore.gypi:-4608
> -            'plugins/gtk/PluginDataGtk.cpp',

This part isn't in my change, so you still might want to do this part.

[Ryan Sleevi]

Created attachment 134684 [details]
Patch

[Adam Barth]

Comment on attachment 134684 [details]
Patch

Thanks.

[WebKit Review Bot]

Comment on attachment 134684 [details]
Patch

Rejecting attachment 134684 [details] from commit-queue.

[e-mail] does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.

[Adam Barth]

Comment on attachment 134684 [details]
Patch

For the record, https://bugs.webkit.org/show_bug.cgi?id=82677 is the patch that has the other parts of this change.

[WebKit Review Bot]

Comment on attachment 134684 [details]
Patch

Clearing flags on attachment: 134684

Committed r112628: <http://trac.webkit.org/changeset/112628>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.