Bug 82649

Summary:

Simplify reporting a main resource error to DocumentLoader and FrameLoader.

Product:

WebKit

Reporter:

Nate Chapin <japhet>

Component:

WebCore Misc.

Assignee:

Nate Chapin <japhet>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, ap, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	none

Nate Chapin

Reported 2012-03-29 13:32:08 PDT

There's a concept of a "complete" main resource error, which is obsolete, since all errors are complete. Also, there's a call sequence of MainResourceLoader -> FrameLoader -> DocumentLoader -> FrameLoader -> DocumentLoader, which can definitely be simplified.

Attachments
patch (7.79 KB, patch) 2012-03-29 13:36 PDT, Nate Chapin	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Nate Chapin

Comment 1 2012-03-29 13:36:50 PDT

Created attachment 134657 [details] patch

Adam Barth

Comment 2 2012-03-29 14:37:55 PDT

I'm imagining reading this patch in reverse. "Introduce a paramater that's always true..."

WebKit Review Bot

Comment 3 2012-03-29 16:17:29 PDT

Comment on attachment 134657 [details] patch Clearing flags on attachment: 134657 Committed r112599: <http://trac.webkit.org/changeset/112599>

WebKit Review Bot

Comment 4 2012-03-29 16:17:34 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.