Bug 82637

Summary: Template the Yarr::Interpreter on the character type
Product: WebKit Reporter: Gavin Barraclough <barraclough>
Component: JavaScriptCoreAssignee: Gavin Barraclough <barraclough>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Fix sam: review+, buildbot: commit-queue-

Description Gavin Barraclough 2012-03-29 12:10:09 PDT 
We should be able to call to the interpreter after having already checked the character type, without having to re-package the character pointer back up into a string!
Comment 1 Gavin Barraclough 2012-03-29 12:13:00 PDT 
Created attachment 134638 [details]
Fix

No performance impact
Comment 2 WebKit Review Bot 2012-03-29 12:18:05 PDT 
Attachment 134638 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1
Source/JavaScriptCore/yarr/YarrInterpreter.h:380:  The parameter name "bytecode" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/yarr/YarrInterpreter.h:381:  The parameter name "bytecode" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 2 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Build Bot 2012-03-29 12:47:27 PDT 
Comment on attachment 134638 [details]
Fix

Attachment 134638 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/12204402
Comment 4 Sam Weinig 2012-03-29 13:05:46 PDT 
Comment on attachment 134638 [details]
Fix

You are windows breaker!
Comment 5 Gavin Barraclough 2012-03-29 13:16:54 PDT 
Fixed in r112564