Bug 82626
| Summary: | Rebaseline media elements tests after r112484 | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Enrica Casucci <enrica> |
| Component: | Media | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bdakin, eric.carlson, vcarbune |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Mac | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 82124 | ||
Enrica Casucci
The following tests need a new baseline:
media/media-document-audio-repaint.html
media/video-no-audio.html
media/controls-strict.html
media/video-volume-slider.html
media/controls-styling.html
media/video-display-toggle.html
media/audio-repaint.html
media/audio-controls-rendering.html
media/video-zoom-controls.html
media/video-controls-rendering.html
media/controls-without-preload.html
media/media-controls-clone.html
fast/layers/video-layer.html
media/video-empty-source.html
media/video-playing-and-pause.html
media/controls-after-reload.html
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Victor Carbune
(In reply to comment #0)
> The following tests need a new baseline:
>
> media/media-document-audio-repaint.html
> media/video-no-audio.html
> media/controls-strict.html
> media/video-volume-slider.html
> media/controls-styling.html
> media/video-display-toggle.html
> media/audio-repaint.html
> media/audio-controls-rendering.html
> media/video-zoom-controls.html
> media/video-controls-rendering.html
> media/controls-without-preload.html
> media/media-controls-clone.html
> fast/layers/video-layer.html
> media/video-empty-source.html
> media/video-playing-and-pause.html
> media/controls-after-reload.html
I will look into this as soon as I get access to a mac build system, but in the meantime I'm wondering why these weren't caught by the Mac EWS bot.
Alexey Proskuryakov
The Mac EWS bot only builds, and doesn't run tests currently.
Victor, when do you expect to have an opportunity to work on this?
Victor Carbune
(In reply to comment #2)
> The Mac EWS bot only builds, and doesn't run tests currently.
Thanks for clarifying this. Is this true for the rest of the EWS bots well (GTK, Qt?)
> Victor, when do you expect to have an opportunity to work on this?
Right now the change breaking these has been rolled out. I have fixed the patch for the mac build as well and I'm trying to figure out how to properly generate new baselines.
Beth Dakin
The patch has been landed again, and the tests are still failing. We need to fix them or roll out the patch again.
Victor Carbune
I have submitted the new baselines with the initial patch
http://trac.webkit.org/changeset/114957