Bug 82606

Summary: Web Inspector: use canvas to render bars in "vertical overview" mode
Product: WebKit Reporter: Andrey Kosyakov <caseq>
Component: Web Inspector (Deprecated)Assignee: Andrey Kosyakov <caseq>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch pfeldman: review+

Description Andrey Kosyakov 2012-03-29 06:17:23 PDT 
This gives us better accuracy when mapping window selection to bars compared to flex boxes and slightly improves performance.
This also gives us better control over spacing between bars.
Comment 1 Andrey Kosyakov 2012-03-29 06:18:57 PDT 
Created attachment 134561 [details]
Patch
Comment 2 Pavel Feldman 2012-03-29 06:21:42 PDT 
Comment on attachment 134561 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=134561&action=review

> Source/WebCore/ChangeLog:8
> +        * inspector/front-end/TimelineOverviewPane.js:

What and why did change? It sounds like you need to generate some text here even for trivial changes like this.
Comment 3 Andrey Kosyakov 2012-03-29 06:28:46 PDT 
Created attachment 134563 [details]
Patch
Comment 4 Andrey Kosyakov 2012-03-29 06:31:21 PDT 
(In reply to comment #2)
> (From update of attachment 134561 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=134561&action=review
> 
> > Source/WebCore/ChangeLog:8
> > +        * inspector/front-end/TimelineOverviewPane.js:
> 
> What and why did change? It sounds like you need to generate some text here even for trivial changes like this.

I added a couple of lines there. Please let me know if this is more comprehensible now or if you see a better summary for what was done.
Comment 5 Andrey Kosyakov 2012-03-29 06:48:02 PDT 
Committed r112528: <http://trac.webkit.org/changeset/112528>