Summary: | [BlackBerry] Add Internal test support for blackberry porting. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Charles Wei <charles.wei> | ||||||
Component: | WebKit BlackBerry | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | mxie, rakuco, rwlbuis, staikos, tonikitoo, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Charles Wei
2012-03-29 04:30:13 PDT
Created attachment 134546 [details]
Patch that enables Internal testing support for BlackBerry
Comment on attachment 134546 [details] Patch that enables Internal testing support for BlackBerry View in context: https://bugs.webkit.org/attachment.cgi?id=134546&action=review > Source/WebCore/ChangeLog:8 > + No new tests, just the build system ehancement for BlackBerry porting. Typo ehancement :) > Source/WebCore/UseJSC.cmake:22 > +ENDIF () Is there anything in WebKit/blackberry cmake file that involves internal test support? Comment on attachment 134546 [details] Patch that enables Internal testing support for BlackBerry View in context: https://bugs.webkit.org/attachment.cgi?id=134546&action=review >> Source/WebCore/ChangeLog:8 >> + No new tests, just the build system ehancement for BlackBerry porting. > > Typo ehancement :) Thanks, will fix it with next patch. >> Source/WebCore/UseJSC.cmake:22 >> +ENDIF () > > Is there anything in WebKit/blackberry cmake file that involves internal test support? I don't see why we need WebKit/blackberry cmake file for this. The internal test provides an JavaScript API for internal test, we don't need any WebKit side support on this, if I understand correct. Maybe I missed your point, Rob ? Created attachment 134550 [details]
Patch V2 that fixes some typo in last patch.
Comment on attachment 134550 [details]
Patch V2 that fixes some typo in last patch.
Looks good.
(In reply to comment #3) > > Is there anything in WebKit/blackberry cmake file that involves internal test support? > > I don't see why we need WebKit/blackberry cmake file for this. The internal test provides an JavaScript API for internal test, we don't need any WebKit side support on this, if I understand correct. Maybe I missed your point, Rob ? I just thought we had some lines in our WebKit specific CMakelists.txt for internal testing API, but was not sure. I can check later once I am in the office. Cheers, Rob. (In reply to comment #6) > (In reply to comment #3) > > > Is there anything in WebKit/blackberry cmake file that involves internal test support? > > > > I don't see why we need WebKit/blackberry cmake file for this. The internal test provides an JavaScript API for internal test, we don't need any WebKit side support on this, if I understand correct. Maybe I missed your point, Rob ? > > I just thought we had some lines in our WebKit specific CMakelists.txt for internal testing API, but was not sure. I can check later once I am in the office. > Cheers, > > Rob. Thanks, Rob. I didn't find any related cmake change in WebKit/blackberry, but we can have another patch for that if you do find any. Comment on attachment 134550 [details] Patch V2 that fixes some typo in last patch. Clearing flags on attachment: 134550 Committed r112525: <http://trac.webkit.org/changeset/112525> All reviewed patches have been landed. Closing bug. (In reply to comment #7) > (In reply to comment #6) > > (In reply to comment #3) > > > > Is there anything in WebKit/blackberry cmake file that involves internal test support? > > > > > > I don't see why we need WebKit/blackberry cmake file for this. The internal test provides an JavaScript API for internal test, we don't need any WebKit side support on this, if I understand correct. Maybe I missed your point, Rob ? > > > > I just thought we had some lines in our WebKit specific CMakelists.txt for internal testing API, but was not sure. I can check later once I am in the office. > > Cheers, > > > > Rob. > > Thanks, Rob. I didn't find any related cmake change in WebKit/blackberry, but we can have another patch for that if you do find any. My intuition was good :) We missed this in Source/WebKit/PlatformBlackBerry.cmake: "${WEBCORE_DIR}/testing/js" However we can do a bug fix to bring the whole file up to date later, I am sure there are more changes we need to sync. |