Bug 82591

Summary: [EFL] LayoutTestController needs implementation of isPageBoxVisible
Product: WebKit Reporter: Alexander Shalamov <alexander.shalamov>
Component: WebKit EFLAssignee: Alexander Shalamov <alexander.shalamov>
Severity: Normal CC: gyuyoung.kim, lucas.de.marchi, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 82589    
Description Flags
Patch none

Description Alexander Shalamov 2012-03-29 03:12:43 PDT
LayoutTestController needs implementation of isPageBoxVisible in order to unskip printing/page-format-data.html
Comment 1 Alexander Shalamov 2012-03-29 03:16:59 PDT
Created attachment 134539 [details]

DRT support for isPageBoxVisible
Comment 2 Raphael Kubo da Costa (:rakuco) 2012-03-29 13:10:40 PDT
Comment on attachment 134539 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=134539&action=review

> Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp:124
> +    WebCore::Frame* frame = EWKPrivate::coreFrame(ewkFrame);

Nitpick: could be const.

> Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp:129
> +    return frame->document()->isPageBoxVisible(pageIndex);

Are you guaranteed to always have a valid Document?
Comment 3 Alexander Shalamov 2012-03-30 00:12:40 PDT
Created attachment 134736 [details]

Added fix according to the review comments
Added description to the changelogs
Comment 4 Raphael Kubo da Costa (:rakuco) 2012-03-30 12:52:28 PDT
If this one blocks bug 82589, shouldn't you ask for review for this one and remove the flags in the other bug?
Comment 5 Alexander Shalamov 2012-04-01 22:05:28 PDT
Comment on attachment 134736 [details]

Set review and commit-queue flags.
Comment 6 Gyuyoung Kim 2012-04-01 22:20:27 PDT
Comment on attachment 134736 [details]

Looks fine.
Comment 7 WebKit Review Bot 2012-04-02 22:06:00 PDT
Comment on attachment 134736 [details]

Clearing flags on attachment: 134736

Committed r112985: <http://trac.webkit.org/changeset/112985>
Comment 8 WebKit Review Bot 2012-04-02 22:06:05 PDT
All reviewed patches have been landed.  Closing bug.