Bug 82580

Summary: configure fails during gstreamer detection
Product: WebKit Reporter: Landry Breuil <landry>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: pnormand, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Other   
Attachments:
Description Flags
Fix gstreamer configure detection none

Description Landry Breuil 2012-03-29 01:02:11 PDT
Assigned to webkitgtk but that should be against 'build  system' ... webkitgtk 1.8.0 fails to pass configure on OpenBSD :

checking for GSTREAMER... no
configure: error: Package requirements (gstreamer-0.10 >= GSTREAMER_0_10_REQUIRED_VERSION
                     gstreamer-app-0.10
                     gstreamer-audio-0.10
                     gstreamer-fft-0.10
                     gstreamer-base-0.10
                     gstreamer-interfaces-0.10
                     gstreamer-pbutils-0.10
                     gstreamer-plugins-base-0.10 >= GSTREAMER_0_10_PLUGINS_BASE_REQUIRED_VERSION
                     gstreamer-video-0.10) were not met:

Package >= was not found in the pkg-config search path
Package GSTREAMER_0_10_REQUIRED_VERSION was not found in the pkg-config search path
Package GSTREAMER_0_10_PLUGINS_BASE_REQUIRED_VERSION was not found in the pkg-config search path

http://trac.webkit.org/changeset/106340 introduces a problem with variable assignation in configure :

+ case "$with_gstreamer" in
+-     0.10) GSTREAMER_REQUIRED_VERSION=GSTREAMER_0_10_REQUIRED_VERSION
+-           GSTREAMER_PLUGINS_BASE_REQUIRED_VERSION=GSTREAMER_0_10_PLUGINS_BASE_REQUIRED_VERSION
++     0.10) GSTREAMER_REQUIRED_VERSION=$GSTREAMER_0_10_REQUIRED_VERSION
++           GSTREAMER_PLUGINS_BASE_REQUIRED_VERSION=$GSTREAMER_0_10_PLUGINS_BASE_REQUIRED_VERSION

That change fixes the issue for me. If it's confirmed and not yet fixed/dupe, i'll make a proper patch against configure.ac fixing the 0.11 codepath too.
Comment 1 Philippe Normand 2012-04-19 14:38:11 PDT
Interesting, I wonder why the buildbots don't bother about this issue... Will send a patch, thanks for reporting!
Comment 2 Philippe Normand 2012-04-19 14:39:09 PDT
Or feel free to send the patch, I'd be happy to review it :)
Comment 3 Landry Breuil 2012-04-24 15:09:06 PDT
Created attachment 138659 [details]
Fix gstreamer configure detection

Here you are..
Comment 4 WebKit Review Bot 2012-05-01 11:04:06 PDT
Comment on attachment 138659 [details]
Fix gstreamer configure detection

Clearing flags on attachment: 138659

Committed r115737: <http://trac.webkit.org/changeset/115737>
Comment 5 WebKit Review Bot 2012-05-01 11:04:16 PDT
All reviewed patches have been landed.  Closing bug.