Bug 82578

Summary: Pack bitfields in InlineBox for Windows
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: New BugsAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, eric, kling, koivisto, krit, mitz, morrita, ojan, tkent, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Initial attempt none

Ryosuke Niwa
Reported 2012-03-29 00:44:39 PDT
Pack bitfields in InlineBox for Windows
Attachments
Initial attempt (59.36 KB, patch)
2012-03-29 00:55 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2012-03-29 00:55:24 PDT
Created attachment 134519 [details] Initial attempt
Kent Tamura
Comment 2 2012-03-29 02:07:20 PDT
Comment on attachment 134519 [details] Initial attempt Looks good.
WebKit Review Bot
Comment 3 2012-03-29 02:49:01 PDT
Comment on attachment 134519 [details] Initial attempt Clearing flags on attachment: 134519 Committed r112512: <http://trac.webkit.org/changeset/112512>
WebKit Review Bot
Comment 4 2012-03-29 02:49:07 PDT
All reviewed patches have been landed. Closing bug.
Ryosuke Niwa
Comment 5 2012-03-29 12:20:32 PDT
Sadly, this change appears to have had no effect on page cycler results: http://build.chromium.org/p/chromium.webkit/builders/Vista%20Perf/builds/9443
Eric Seidel (no email)
Comment 6 2012-03-29 12:39:12 PDT
Do we know from COMPILE_ASSERTS that we definitely made these smaller on Win?
Ryosuke Niwa
Comment 7 2012-03-29 13:54:21 PDT
(In reply to comment #6) > Do we know from COMPILE_ASSERTS that we definitely made these smaller on Win? Yes. The InlineBox's size was reduced from 40 bytes to 36 bytes. So that's about 10% reduction in its size. Maybe the size of InlineBox doesn't matter as much. It's possible that we're over-optimzing in this area.
Ryosuke Niwa
Comment 8 2012-03-29 14:08:58 PDT
Of course, it might also mean that we don't have good tests.
Note You need to log in before you can comment on or make changes to this bug.