Bug 82573

Summary: [BlackBerry] Turn on STORE_FONT_CUSTOM_PLATFORM_DATA in CachedFont.cpp
Product: WebKit Reporter: Leo Yang <leo.yang>
Component: WebKit BlackBerryAssignee: Leo Yang <leo.yang>
Status: RESOLVED FIXED    
Severity: Normal CC: charles.wei, japhet, rwlbuis, staikos, tonikitoo, webkit.review.bot, zimmermann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 73144    
Attachments:
Description Flags
Patch
rwlbuis: review+
Patch for landing none

Leo Yang
Reported 2012-03-28 22:34:38 PDT
Turn on STORE_FONT_CUSTOM_PLATFORM_DATA in CachedFont.cpp for blackberry porting.
Attachments
Patch (1.77 KB, patch)
2012-03-28 22:38 PDT, Leo Yang 		rwlbuis: review+
DetailsFormatted DiffDiff
Patch for landing (1.80 KB, patch)
2012-03-29 18:43 PDT, Leo Yang 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Leo Yang
Comment 1 2012-03-28 22:38:42 PDT
Created attachment 134501 [details] Patch
Rob Buis
Comment 2 2012-03-29 06:53:17 PDT
Comment on attachment 134501 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=134501&action=review Looks good. > Source/WebCore/ChangeLog:7 > + You should mention here that it is covered by existing tests.
Leo Yang
Comment 3 2012-03-29 18:43:05 PDT
Created attachment 134709 [details] Patch for landing
Leo Yang
Comment 4 2012-03-29 18:44:41 PDT
(In reply to comment #2) > (From update of attachment 134501 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=134501&action=review > > Looks good. > > > Source/WebCore/ChangeLog:7 > > + > > You should mention here that it is covered by existing tests. I added this in the revised patch. Thanks for your review.
WebKit Review Bot
Comment 5 2012-03-29 20:04:41 PDT
Comment on attachment 134709 [details] Patch for landing Clearing flags on attachment: 134709 Committed r112640: <http://trac.webkit.org/changeset/112640>
WebKit Review Bot
Comment 6 2012-03-29 20:04:46 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.