Bug 82567

Summary: [BlackBerry] Sync up PlatformMouseEvent
Product: WebKit Reporter: Leo Yang <leo.yang>
Component: WebKit BlackBerryAssignee: Leo Yang <leo.yang>
Status: RESOLVED FIXED    
Severity: Normal CC: charles.wei, rwlbuis, staikos, tonikitoo, webkit.review.bot, zimmermann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 73144    
Attachments:
Description Flags
Patch none

Description Leo Yang 2012-03-28 20:35:48 PDT
This is to upstream the blackberry specific changes to PlatformMouseEvent.h and sync up the blackberry specific PlatformMouseEventBlackBerry.
Comment 1 Leo Yang 2012-03-28 21:05:16 PDT
Created attachment 134490 [details]
Patch
Comment 2 Rob Buis 2012-03-29 04:13:05 PDT
Comment on attachment 134490 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=134490&action=review

> Source/WebCore/platform/PlatformMouseEvent.h:60
> +    enum MouseInputMethod { PointingDevice, TouchScreen };

Don't we have TouchEvent for TouchScreen?
Comment 3 Leo Yang 2012-03-29 19:10:21 PDT
(In reply to comment #2)
> (From update of attachment 134490 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=134490&action=review
> 
> > Source/WebCore/platform/PlatformMouseEvent.h:60
> > +    enum MouseInputMethod { PointingDevice, TouchScreen };
> 
> Don't we have TouchEvent for TouchScreen?

For single touch events (touch point press/release, etc), we convert them to PlatformMouse events and send them to WebCore. This is reasonable since single touch is very like mouse click.
Comment 4 Rob Buis 2012-03-29 19:29:25 PDT
Comment on attachment 134490 [details]
Patch

Looks good.
Comment 5 Leo Yang 2012-03-29 19:32:55 PDT
(In reply to comment #4)
> (From update of attachment 134490 [details])
> Looks good.

Thanks for your review.
Comment 6 WebKit Review Bot 2012-03-29 20:32:03 PDT
Comment on attachment 134490 [details]
Patch

Clearing flags on attachment: 134490

Committed r112641: <http://trac.webkit.org/changeset/112641>
Comment 7 WebKit Review Bot 2012-03-29 20:32:08 PDT
All reviewed patches have been landed.  Closing bug.