Summary: | Change WebKit/WebKit2 platform code to use pixel snapped values | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Emil A Eklund <eae> | ||||
Component: | Platform | Assignee: | Emil A Eklund <eae> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | andersca, eric, hyatt, leviw, mitz, simon.fraser, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 60318 | ||||||
Attachments: |
|
Description
Emil A Eklund
2012-03-28 16:34:20 PDT
Created attachment 134444 [details]
Patch
Comment on attachment 134444 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=134444&action=review > Source/WebCore/dom/Node.h:380 > LayoutRect renderRect(bool* isReplaced); > + IntRect pixelSnappedRenderRect(bool* isReplaced) { return pixelSnappedIntRect(renderRect(isReplaced)); } Wouldn't this be easier to call renderRect().pixelSnapped() in the caller instead? (In reply to comment #2) > (From update of attachment 134444 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=134444&action=review > > > Source/WebCore/dom/Node.h:380 > > LayoutRect renderRect(bool* isReplaced); > > + IntRect pixelSnappedRenderRect(bool* isReplaced) { return pixelSnappedIntRect(renderRect(isReplaced)); } > > Wouldn't this be easier to call renderRect().pixelSnapped() in the caller instead? It would but that would break the encapsulation and expose LayoutRects to the WebKit platform code, something we have been trying to avoid. Ping? Comment on attachment 134444 [details]
Patch
Thank you for the ping.
Comment on attachment 134444 [details]
Patch
Thanks for the review!
Comment on attachment 134444 [details] Patch Clearing flags on attachment: 134444 Committed r112758: <http://trac.webkit.org/changeset/112758> All reviewed patches have been landed. Closing bug. |