Summary: | Change FilterOperations::getOutsets to use integers | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Emil A Eklund <eae> | ||||
Component: | Layout and Rendering | Assignee: | Emil A Eklund <eae> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | eric, krit, leviw, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 60318, 83041 | ||||||
Attachments: |
|
Description
Emil A Eklund
2012-03-28 15:04:05 PDT
Created attachment 134413 [details]
Patch
Comment on attachment 134413 [details]
Patch
Ha! Yes, these make no sense as LayoutUnits. :)
wouldn't it be easier to replace the 4 ints by one IntRect? (In reply to comment #3) > wouldn't it be easier to replace the 4 ints by one IntRect? Would be easier but as the numbers don't really represent a rectangle it would be a bit confusing. Perhaps we need some new data type for things like borders, outsets, margins and paddings where you have a value for each edge. Comment on attachment 134413 [details] Patch Clearing flags on attachment: 134413 Committed r112475: <http://trac.webkit.org/changeset/112475> All reviewed patches have been landed. Closing bug. |