Bug 82533 – [Qt][WK2] Remove all USE(TILED_BACKING_STORE) defines from code that contains UI_SIDE_COMPOSITING

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[Noam Rosenthal]

[Qt][WK2] Remove all USE(TILED_BACKING_STORE) defines from code that contains UI_SIDE_COMPOSITING

[Noam Rosenthal]

Created attachment 134415 [details]
Patch

[Jocelyn Turcotte]

Comment on attachment 134415 [details]
Patch

LGTM, TILED_BACKING_STORE guards don't have much value in WK2 anyway. We should also remove its support from WebCore if we ever can.

[Kenneth Rohde Christiansen]

Comment on attachment 134415 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=134415&action=review

> Source/WebKit2/WebProcess/WebCoreSupport/WebGraphicsLayer.h:123
>  
> -#if USE(TILED_BACKING_STORE)
>      // TiledBackingStoreClient
>      virtual void tiledBackingStorePaintBegin();
>      virtual void tiledBackingStorePaint(GraphicsContext*, const IntRect&);

So isn't this header shared across ports? Won't this break mac etc?

[Noam Rosenthal]

(In reply to comment #3)
> (From update of attachment 134415 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=134415&action=review
> 
> > Source/WebKit2/WebProcess/WebCoreSupport/WebGraphicsLayer.h:123
> >  
> > -#if USE(TILED_BACKING_STORE)
> >      // TiledBackingStoreClient
> >      virtual void tiledBackingStorePaintBegin();
> >      virtual void tiledBackingStorePaint(GraphicsContext*, const IntRect&);
> 
> So isn't this header shared across ports? Won't this break mac etc?

No, this header is only for UI_SIDE_COMPOSITING.

[Kenneth Rohde Christiansen]

Comment on attachment 134415 [details]
Patch

ok then

[alan]

(In reply to comment #2)
> (From update of attachment 134415 [details])
> LGTM, TILED_BACKING_STORE guards don't have much value in WK2 anyway. We should also remove its support from WebCore if we ever can.

agree, especially with its mixture with fixed layout at some places at the webprocess side.

[Noam Rosenthal]

Created attachment 136255 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 136255 [details]
Patch for landing

Clearing flags on attachment: 136255

Committed r113610: <http://trac.webkit.org/changeset/113610>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.