Bug 82533

Summary:

[Qt][WK2] Remove all USE(TILED_BACKING_STORE) defines from code that contains UI_SIDE_COMPOSITING

Product:

WebKit

Reporter:

Noam Rosenthal <noam>

Component:

Layout and Rendering

Assignee:

Noam Rosenthal <noam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

hausmann, jturcotte, kenneth, webkit.review.bot, zalan

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

75780

Attachments:

Description	Flags
Patch	none
Patch for landing	none

Description Noam Rosenthal 2012-03-28 14:49:06 PDT

[Qt][WK2] Remove all USE(TILED_BACKING_STORE) defines from code that contains UI_SIDE_COMPOSITING

Comment 1 Noam Rosenthal 2012-03-28 15:10:39 PDT

Created attachment 134415 [details]
Patch

Comment 2 Jocelyn Turcotte 2012-03-29 05:06:57 PDT

Comment on attachment 134415 [details]
Patch

LGTM, TILED_BACKING_STORE guards don't have much value in WK2 anyway. We should also remove its support from WebCore if we ever can.

Comment 3 Kenneth Rohde Christiansen 2012-03-29 05:11:02 PDT

Comment on attachment 134415 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=134415&action=review

> Source/WebKit2/WebProcess/WebCoreSupport/WebGraphicsLayer.h:123
>  
> -#if USE(TILED_BACKING_STORE)
>      // TiledBackingStoreClient
>      virtual void tiledBackingStorePaintBegin();
>      virtual void tiledBackingStorePaint(GraphicsContext*, const IntRect&);

So isn't this header shared across ports? Won't this break mac etc?

Comment 4 Noam Rosenthal 2012-03-29 06:48:36 PDT

(In reply to comment #3)
> (From update of attachment 134415 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=134415&action=review
> 
> > Source/WebKit2/WebProcess/WebCoreSupport/WebGraphicsLayer.h:123
> >  
> > -#if USE(TILED_BACKING_STORE)
> >      // TiledBackingStoreClient
> >      virtual void tiledBackingStorePaintBegin();
> >      virtual void tiledBackingStorePaint(GraphicsContext*, const IntRect&);
> 
> So isn't this header shared across ports? Won't this break mac etc?

No, this header is only for UI_SIDE_COMPOSITING.

Comment 5 Kenneth Rohde Christiansen 2012-03-29 06:49:43 PDT

Comment on attachment 134415 [details]
Patch

ok then

Comment 6 zalan 2012-03-29 06:58:27 PDT

(In reply to comment #2)
> (From update of attachment 134415 [details])
> LGTM, TILED_BACKING_STORE guards don't have much value in WK2 anyway. We should also remove its support from WebCore if we ever can.

agree, especially with its mixture with fixed layout at some places at the webprocess side.

Comment 7 Noam Rosenthal 2012-04-09 10:15:07 PDT

Created attachment 136255 [details]
Patch for landing

Comment 8 WebKit Review Bot 2012-04-09 13:26:22 PDT

Comment on attachment 136255 [details]
Patch for landing

Clearing flags on attachment: 136255

Committed r113610: <http://trac.webkit.org/changeset/113610>

Comment 9 WebKit Review Bot 2012-04-09 13:26:26 PDT

All reviewed patches have been landed.  Closing bug.