Bug 82525

Summary:

[Qt][WK2] Direct composited image assignment doesn't work

Product:

WebKit

Reporter:

Noam Rosenthal <noam>

Component:

Layout and Rendering

Assignee:

Noam Rosenthal <noam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

hausmann, jturcotte, kenneth, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

75780

Attachments:

Description	Flags
Patch	none
Patch for landing	none
Patch for landing	none

Description Noam Rosenthal 2012-03-28 14:04:36 PDT

[Qt][WK2] Direct composited image assignment doesn't work

Comment 1 Noam Rosenthal 2012-03-28 15:11:14 PDT

Created attachment 134416 [details]
Patch

Comment 2 Jocelyn Turcotte 2012-03-29 05:07:03 PDT

Comment on attachment 134416 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=134416&action=review

LGTM, just one thing.

> Source/WebKit2/UIProcess/WebLayerTreeRenderer.cpp:-176
> -    bool needsToUpdateImageTiles = layerInfo.imageIsUpdated || (layerInfo.contentsRect != layer->contentsRect() && layerInfo.imageBackingStoreID);

Please remove imageIsUpdated from WebLayerInfo::flags

Comment 3 Noam Rosenthal 2012-03-29 15:01:40 PDT

Created attachment 134674 [details]
Patch for landing

Comment 4 Noam Rosenthal 2012-03-29 15:16:08 PDT

Created attachment 134680 [details]
Patch for landing

Comment 5 WebKit Review Bot 2012-03-29 17:21:18 PDT

Comment on attachment 134680 [details]
Patch for landing

Clearing flags on attachment: 134680

Committed r112617: <http://trac.webkit.org/changeset/112617>

Comment 6 WebKit Review Bot 2012-03-29 17:21:23 PDT

All reviewed patches have been landed.  Closing bug.