Bug 82524

Summary: [CSS Filters] Avoid rebuilding FEFilters when RenderLayer is destroyed
Product: WebKit Reporter: Alexandru Chiculita <achicu>
Component: Layout and RenderingAssignee: Alexandru Chiculita <achicu>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, webkit-bug-importer, webkit.review.bot
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch V1 none

Alexandru Chiculita
Reported 2012-03-28 14:01:13 PDT
RenderLayer::updateOrRemoveFilterEffect is called in clearBacking(), which is called from RenderLayer::~RenderLayer, meaning that the filters are rebuild when deleting a layer, but they are not going to be used anyway. Avoid creating new filters when the RenderLayer is going out of scope.
Attachments
Patch V1 (2.74 KB, patch)
2012-03-28 15:25 PDT, Alexandru Chiculita 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2012-03-28 14:44:40 PDT
<rdar://problem/11141839>
Alexandru Chiculita
Comment 2 2012-03-28 15:25:19 PDT
Created attachment 134422 [details] Patch V1
WebKit Review Bot
Comment 3 2012-03-28 20:43:06 PDT
Comment on attachment 134422 [details] Patch V1 Clearing flags on attachment: 134422 Committed r112497: <http://trac.webkit.org/changeset/112497>
WebKit Review Bot
Comment 4 2012-03-28 20:43:10 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.