Bug 82523

Summary: [Qt][WK2] Disable the content-scaling and visible contents rect when the layer's transform is not affine
Product: WebKit Reporter: Noam Rosenthal <noam>
Component: Layout and RenderingAssignee: Noam Rosenthal <noam>
Status: RESOLVED FIXED    
Severity: Normal CC: hausmann, jturcotte, kenneth, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 75780    
Attachments:
Description Flags
Patch
none
Patch for landing none

Noam Rosenthal
Reported 2012-03-28 13:58:10 PDT
[Qt][WK2] Disable the content-scaling and visible contents rect when the layer's transform is not affine
Attachments
Patch (5.67 KB, patch)
2012-03-28 15:06 PDT, Noam Rosenthal 		no flags
DetailsFormatted DiffDiff
Patch for landing (5.67 KB, patch)
2012-04-09 10:13 PDT, Noam Rosenthal 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Noam Rosenthal
Comment 1 2012-03-28 15:06:41 PDT
Created attachment 134410 [details] Patch
Jocelyn Turcotte
Comment 2 2012-03-29 05:07:06 PDT
Comment on attachment 134410 [details] Patch LGTM
Kenneth Rohde Christiansen
Comment 3 2012-03-29 05:14:13 PDT
Comment on attachment 134410 [details] Patch Can this be tested?
Noam Rosenthal
Comment 4 2012-03-29 06:47:38 PDT
(In reply to comment #3) > (From update of attachment 134410 [details]) > Can this be tested? It's already tested. The compositing tests with huge transformed layers test this.
Kenneth Rohde Christiansen
Comment 5 2012-04-03 07:13:19 PDT
Comment on attachment 134410 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=134410&action=review > Source/WebKit2/ChangeLog:8 > + Always use contentsScale of 1 and a full visibleContentsRect when I hate the name for visibleContentsRect when it is more than that, especially if people use it differently
Noam Rosenthal
Comment 6 2012-04-03 07:23:22 PDT
(In reply to comment #5) > (From update of attachment 134410 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=134410&action=review > > > Source/WebKit2/ChangeLog:8 > > + Always use contentsScale of 1 and a full visibleContentsRect when > > I hate the name for visibleContentsRect when it is more than that, especially if people use it differently It should probably be "visibleRectInContentsCoordinates". Though that's an issue for another patch...
Noam Rosenthal
Comment 7 2012-04-09 09:39:08 PDT
Any other issues with this patch?
Noam Rosenthal
Comment 8 2012-04-09 10:13:28 PDT
Created attachment 136254 [details] Patch for landing
WebKit Review Bot
Comment 9 2012-04-09 13:01:42 PDT
Comment on attachment 136254 [details] Patch for landing Clearing flags on attachment: 136254 Committed r113608: <http://trac.webkit.org/changeset/113608>
WebKit Review Bot
Comment 10 2012-04-09 13:01:47 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.