Summary: | [Qt][WK2] Disable the content-scaling and visible contents rect when the layer's transform is not affine | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Noam Rosenthal <noam> | ||||||
Component: | Layout and Rendering | Assignee: | Noam Rosenthal <noam> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | hausmann, jturcotte, kenneth, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 75780 | ||||||||
Attachments: |
|
Description
Noam Rosenthal
2012-03-28 13:58:10 PDT
Created attachment 134410 [details]
Patch
Comment on attachment 134410 [details]
Patch
LGTM
Comment on attachment 134410 [details]
Patch
Can this be tested?
(In reply to comment #3) > (From update of attachment 134410 [details]) > Can this be tested? It's already tested. The compositing tests with huge transformed layers test this. Comment on attachment 134410 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=134410&action=review > Source/WebKit2/ChangeLog:8 > + Always use contentsScale of 1 and a full visibleContentsRect when I hate the name for visibleContentsRect when it is more than that, especially if people use it differently (In reply to comment #5) > (From update of attachment 134410 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=134410&action=review > > > Source/WebKit2/ChangeLog:8 > > + Always use contentsScale of 1 and a full visibleContentsRect when > > I hate the name for visibleContentsRect when it is more than that, especially if people use it differently It should probably be "visibleRectInContentsCoordinates". Though that's an issue for another patch... Any other issues with this patch? Created attachment 136254 [details]
Patch for landing
Comment on attachment 136254 [details] Patch for landing Clearing flags on attachment: 136254 Committed r113608: <http://trac.webkit.org/changeset/113608> All reviewed patches have been landed. Closing bug. |