Bug 82490

Summary: Split WebKitCSSKeyframeRule into internal and CSSOM types
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: kling, macpherson, menard, simon.fraser, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 77745    
Attachments:
Description Flags
patch kling: review+

Antti Koivisto
Reported 2012-03-28 11:19:22 PDT
WebKitCSSKeyframeRule is a CSSOM type and should not be used internally.
Attachments
patch (29.27 KB, patch)
2012-03-28 13:54 PDT, Antti Koivisto 		kling: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2012-03-28 13:54:08 PDT
Created attachment 134388 [details] patch
WebKit Review Bot
Comment 2 2012-03-28 13:57:41 PDT
Attachment 134388 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/css/CSSStyleSelector.cpp:1632: Local variables should never be PassRefPtr (see http://webkit.org/coding/RefPtr.html). [readability/pass_ptr] [5] Total errors found: 1 in 13 files If any of these errors are false positives, please file a bug against check-webkit-style.
Alexis Menard (darktears)
Comment 3 2012-03-28 14:21:43 PDT
Comment on attachment 134388 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=134388&action=review > Source/WebCore/css/WebKitCSSKeyframeRule.cpp:49 > + Oops. > Source/WebCore/css/WebKitCSSKeyframeRule.cpp:-81 > - Oops.
Antti Koivisto
Comment 4 2012-04-11 20:58:41 PDT
http://trac.webkit.org/changeset/112516
Note You need to log in before you can comment on or make changes to this bug.