| Summary: | Split WebKitCSSKeyframeRule into internal and CSSOM types | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Antti Koivisto <koivisto> | ||||
| Component: | CSS | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | kling, macpherson, menard, simon.fraser, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 77745 | ||||||
| Attachments: |
|
||||||
|
Description
Antti Koivisto
2012-03-28 11:19:22 PDT
Created attachment 134388 [details]
patch
Attachment 134388 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/css/CSSStyleSelector.cpp:1632: Local variables should never be PassRefPtr (see http://webkit.org/coding/RefPtr.html). [readability/pass_ptr] [5] Total errors found: 1 in 13 files If any of these errors are false positives, please file a bug against check-webkit-style. Comment on attachment 134388 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=134388&action=review > Source/WebCore/css/WebKitCSSKeyframeRule.cpp:49 > + Oops. > Source/WebCore/css/WebKitCSSKeyframeRule.cpp:-81 > - Oops. |