Bug 82481

Summary: Web Inspector: refactor UI breakpoint listeners.
Product: WebKit Reporter: Pavel Podivilov <podivilov>
Component: Web Inspector (Deprecated)Assignee: Pavel Podivilov <podivilov>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch vsevik: review+

Pavel Podivilov
Reported 2012-03-28 10:43:26 PDT
Web Inspector: refactor UI breakpoint listeners. Breakpoint-added and breakpoint-removed events are now dispatched on UISourceCode. So handlers that manage SourceFrame's breakpoint decorations could be moved from ScriptsPanel to SourceFrame.
Attachments
Patch (18.06 KB, patch)
2012-03-28 10:47 PDT, Pavel Podivilov 		no flags
DetailsFormatted DiffDiff
Patch (18.12 KB, patch)
2012-03-28 10:55 PDT, Pavel Podivilov 		vsevik: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Pavel Podivilov
Comment 1 2012-03-28 10:47:34 PDT
Created attachment 134335 [details] Patch
WebKit Review Bot
Comment 2 2012-03-28 10:51:33 PDT
Attachment 134335 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/http..." exit_code: 1 LayoutTests/ChangeLog:1: Line contains tab character. [whitespace/tab] [5] Total errors found: 1 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.
Pavel Podivilov
Comment 3 2012-03-28 10:55:25 PDT
Created attachment 134337 [details] Patch
Vsevolod Vlasov
Comment 4 2012-03-28 11:02:48 PDT
Comment on attachment 134337 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=134337&action=review > Source/WebCore/inspector/front-end/ScriptsPanel.js:257 > + this._addBreakpointListeners(uiSourceCode); This method adds breakpoint listeners twice now, I don't think this is what you meant to do here. > Source/WebCore/inspector/front-end/SourceFrame.js:-58 > - Loaded: "loaded" Could you please mention removing of this event in the ChangeLog?
Pavel Podivilov
Comment 5 2012-04-02 06:57:36 PDT
Committed r112875: <http://trac.webkit.org/changeset/112875>
Note You need to log in before you can comment on or make changes to this bug.