Bug 82475

Summary: Web Inspector: Add context menu for snippets control.
Product: WebKit Reporter: Vsevolod Vlasov <vsevik>
Component: Web Inspector (Deprecated)Assignee: Vsevolod Vlasov <vsevik>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
none
Patch pfeldman: review+

Vsevolod Vlasov
Reported 2012-03-28 09:58:23 PDT
This is a preliminary implementation of snippets control. We might want to add a more visual one before taking snippets out of experiments.
Attachments
Patch (7.56 KB, patch)
2012-03-28 10:05 PDT, Vsevolod Vlasov 		no flags
DetailsFormatted DiffDiff
Patch (7.74 KB, patch)
2012-03-28 10:08 PDT, Vsevolod Vlasov 		no flags
DetailsFormatted DiffDiff
Patch (7.66 KB, patch)
2012-03-28 10:10 PDT, Vsevolod Vlasov 		pfeldman: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Vsevolod Vlasov
Comment 1 2012-03-28 10:05:03 PDT
Created attachment 134322 [details] Patch
Pavel Feldman
Comment 2 2012-03-28 10:08:14 PDT
Comment on attachment 134322 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=134322&action=review > Source/WebCore/ChangeLog:8 > + * English.lproj/localizedStrings.js: Please explain what is happening in the change. > Source/WebCore/inspector/front-end/ScriptsNavigator.js:296 > + Blank line. > Source/WebCore/inspector/front-end/ScriptsNavigator.js:304 > + event.preventDefault(); ContextMenu.show consumes event for you.
Vsevolod Vlasov
Comment 3 2012-03-28 10:08:52 PDT
Created attachment 134323 [details] Patch
Vsevolod Vlasov
Comment 4 2012-03-28 10:10:38 PDT
Created attachment 134324 [details] Patch
Pavel Feldman
Comment 5 2012-03-28 10:16:50 PDT
Comment on attachment 134324 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=134324&action=review > Source/WebCore/ChangeLog:9 > + We might want to add a more visual one before taking snippets out of experiments. a more discoverable one?
Vsevolod Vlasov
Comment 6 2012-03-28 11:14:05 PDT
Committed r112414: <http://trac.webkit.org/changeset/112414>
Note You need to log in before you can comment on or make changes to this bug.