Bug 82451

Summary:

Web Inspector: use maxJSObjectId provided by back-end.

Product:

WebKit

Reporter:

Ilya Tikhonovsky <loislo>

Component:

Web Inspector (Deprecated)

Assignee:

Ilya Tikhonovsky <loislo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, apavlov, bweinstein, dglazkov, gustavo, haraken, japhet, joepeck, keishi, loislo, pfeldman, pmuellr, pnormand, rik, timothy, webkit.review.bot, xan.lopez, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

83008

Bug Blocks:

Attachments:

Description	Flags
Patch	yurys: review+, webkit-ews: commit-queue-

Ilya Tikhonovsky

Reported 2012-03-28 04:59:26 PDT

Summary view can filter objects in snapshot. It uses maxJSObjectId for this. There is no such field in the profile header at the moment but I've landed a patch in downstream.

Attachments
Patch (7.76 KB, patch) 2012-04-03 01:06 PDT, Ilya Tikhonovsky	yurys: review+ webkit-ews: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Ilya Tikhonovsky

Comment 1 2012-04-03 01:06:13 PDT

Created attachment 135288 [details] Patch

Early Warning System Bot

Comment 2 2012-04-03 01:12:17 PDT

Comment on attachment 135288 [details] Patch Attachment 135288 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/12312955

Gyuyoung Kim

Comment 3 2012-04-03 01:12:49 PDT

Comment on attachment 135288 [details] Patch Attachment 135288 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/12322009

Yury Semikhatsky

Comment 4 2012-04-03 01:13:37 PDT

Comment on attachment 135288 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=135288&action=review > Source/WebCore/inspector/front-end/DetailedHeapshotView.js:279 > + if (this._filterProfileIndex !== -1) { Could you use profileIndex here as well(just for clarity)?

Early Warning System Bot

Comment 5 2012-04-03 01:15:37 PDT

Comment on attachment 135288 [details] Patch Attachment 135288 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/12322010

Philippe Normand

Comment 6 2012-04-03 01:18:27 PDT

Comment on attachment 135288 [details] Patch Attachment 135288 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/12320023

WebKit Review Bot

Comment 7 2012-04-03 01:27:36 PDT

Comment on attachment 135288 [details] Patch Attachment 135288 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12321013

Build Bot

Comment 8 2012-04-03 01:28:34 PDT

Comment on attachment 135288 [details] Patch Attachment 135288 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/12321014