Summary: | [chromium] MediaStream API (JSEP): Introducing WebPeerConnection00Handler | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Tommy Widenflycht <tommyw> | ||||
Component: | WebKit API | Assignee: | Tommy Widenflycht <tommyw> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, dglazkov, fishd, jamesr, tkent, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 80589 | ||||||
Attachments: |
|
Description
Tommy Widenflycht
2012-03-28 04:53:30 PDT
Created attachment 134272 [details]
Patch
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. Comment on attachment 134272 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=134272&action=review I'm marking this cq+ to avoid the over night round-trip, but please post a followup patch that adds the comment below. Many thanks! > Source/WebKit/chromium/bridge/PeerConnection00HandlerInternal.cpp:60 > + m_webHandler = adoptPtr(WebKit::webKitPlatformSupport()->createPeerConnection00Handler(this)); Can this fail? > Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h:413 > virtual WebPeerConnectionHandler* createPeerConnectionHandler(WebPeerConnectionHandlerClient*) { return 0; } > + virtual WebPeerConnection00Handler* createPeerConnection00Handler(WebPeerConnection00HandlerClient*) { return 0; } Can you add a comment explaining the difference between these two? This probably looks confusing for folks who haven't been following this discussion in detail. Comment on attachment 134272 [details] Patch Clearing flags on attachment: 134272 Committed r112421: <http://trac.webkit.org/changeset/112421> All reviewed patches have been landed. Closing bug. Comment on attachment 134272 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=134272&action=review >> Source/WebKit/chromium/bridge/PeerConnection00HandlerInternal.cpp:60 >> + m_webHandler = adoptPtr(WebKit::webKitPlatformSupport()->createPeerConnection00Handler(this)); > > Can this fail? Yes, it can if something erroneous happens in the Chromium code for example. There is a comment regarding this in WebKitPlatformSupport.h. >> Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h:413 >> + virtual WebPeerConnection00Handler* createPeerConnection00Handler(WebPeerConnection00HandlerClient*) { return 0; } > > Can you add a comment explaining the difference between these two? This probably looks confusing for folks who haven't been following this discussion in detail. Will do. |