Bug 82444

Summary: [BlackBerry] Clean up ImageBufferData
Product: WebKit Reporter: Robin Cao <robin.webkit>
Component: WebKit BlackBerryAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: anilsson, charles.wei, fspacek, rwlbuis, staikos, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Other   
Attachments:
Description Flags
patch none

Robin Cao
Reported 2012-03-28 03:36:50 PDT
We need to clean up WebCore/platform/graphics/blackberry/skia/ImageBufferDataSkia.h. m_buffer is not used and should be removed. RefPtr<LayerWebKitThread> m_platformLayer; -->> RefPtr<CanvasLayerWebKitThread> m_platformLayer;
Attachments
patch (1.76 KB, patch)
2012-03-28 20:37 PDT, Robin Cao 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Rob Buis
Comment 1 2012-03-28 04:13:04 PDT
Hi Robin, Make sure to coordinate this with Filip please. Cheers, Rob.
Filip Spacek
Comment 2 2012-03-28 13:57:29 PDT
That's a good cleanup Robin. I'm all for it.
Robin Cao
Comment 3 2012-03-28 20:37:15 PDT
Created attachment 134488 [details] patch
Rob Buis
Comment 4 2012-03-29 04:13:54 PDT
Comment on attachment 134488 [details] patch Ok.
WebKit Review Bot
Comment 5 2012-03-29 04:57:12 PDT
Comment on attachment 134488 [details] patch Clearing flags on attachment: 134488 Committed r112519: <http://trac.webkit.org/changeset/112519>
WebKit Review Bot
Comment 6 2012-03-29 04:57:16 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.