Bug 82443

Summary: [EFL] DRT should support LayoutTestController's willSendRequestReturnsNull()
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit EFLAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, lucas.de.marchi, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 82192    
Bug Blocks: 81891    
Attachments:
Description Flags
Proposed patch
none
Proposed patch
none
Proposed patch none

Chris Dumez
Reported 2012-03-28 03:22:52 PDT
EFL's DRT should support LayoutTestController's willSendRequestReturnsNull().
Attachments
Proposed patch (1.45 KB, patch)
2012-03-28 03:27 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Proposed patch (2.99 KB, patch)
2012-03-29 00:25 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Proposed patch (2.79 KB, patch)
2012-04-05 00:07 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2012-03-28 03:27:23 PDT
Created attachment 134252 [details] Proposed patch
Chris Dumez
Comment 2 2012-03-29 00:25:49 PDT
Created attachment 134515 [details] Proposed patch Updated the patch to unskip the associated test cases: # BUG: Support for LayoutTestController::setWillSendRequestReturnsNull not implemented media/media-blocked-by-willsendrequest.html media/video-poster-blocked-by-willsendrequest.html
Gyuyoung Kim
Comment 3 2012-04-04 20:49:31 PDT
Comment on attachment 134515 [details] Proposed patch GTK, mac and win ports also have same logic like this patch. Looks fine.
Chris Dumez
Comment 4 2012-04-05 00:07:39 PDT
Created attachment 135766 [details] Proposed patch Rebase on master and fix changelogs.
Raphael Kubo da Costa (:rakuco)
Comment 5 2012-04-05 18:45:19 PDT
Comment on attachment 135766 [details] Proposed patch Looks good, thanks.
Philippe Normand
Comment 6 2012-04-10 04:20:19 PDT
Comment on attachment 135766 [details] Proposed patch I suspect more tests can be unskipped, can be done later I guess.
WebKit Review Bot
Comment 7 2012-04-10 09:15:37 PDT
Comment on attachment 135766 [details] Proposed patch Clearing flags on attachment: 135766 Committed r113722: <http://trac.webkit.org/changeset/113722>
WebKit Review Bot
Comment 8 2012-04-10 09:15:42 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.