Bug 82420

Summary: [BlackBerry] Use WebCore::PlatformMouseEvent::globalPosition() instead of WebCore::PlatformMouseEvent::globalPos() in WebPage.cpp
Product: WebKit Reporter: Leo Yang <leo.yang>
Component: WebKit BlackBerryAssignee: Leo Yang <leo.yang>
Status: RESOLVED FIXED    
Severity: Normal CC: charles.wei, rwlbuis, staikos, tonikitoo, webkit.review.bot, zimmermann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 73144    
Attachments:
Description Flags
Patch none

Description Leo Yang 2012-03-27 20:03:01 PDT 
In PlatformMouseEvent.h the blackberry porting added globalPos() (but not upstreamed yet) for PlatformMouseEvent, but this method is same as globalPosition() that is available for every porting. We should use globalPosition().
Comment 1 Leo Yang 2012-03-27 20:06:35 PDT 
Created attachment 134208 [details]
Patch
Comment 2 Rob Buis 2012-03-28 04:09:49 PDT 
Comment on attachment 134208 [details]
Patch

LGTM. Can we remove globalPos()?
Comment 3 Leo Yang 2012-03-28 05:09:30 PDT 
(In reply to comment #2)
> (From update of attachment 134208 [details])
> LGTM. Can we remove globalPos()?
Thanks. When I cherry-pick I'll remove it internally.
Comment 4 WebKit Review Bot 2012-03-28 05:31:38 PDT 
Comment on attachment 134208 [details]
Patch

Clearing flags on attachment: 134208

Committed r112385: <http://trac.webkit.org/changeset/112385>
Comment 5 WebKit Review Bot 2012-03-28 05:31:43 PDT 
All reviewed patches have been landed.  Closing bug.