Summary: | [chromium] Merge ChromiumDataObject and DataTransferItemListChromium. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Daniel Cheng <dcheng> | ||||||
Component: | New Bugs | Assignee: | Daniel Cheng <dcheng> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | ||||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Daniel Cheng
2012-03-27 18:27:27 PDT
Created attachment 134191 [details]
Patch
Comment on attachment 134191 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=134191&action=review Looks like your patch needs to be rebased. Please make sure to have a green ews run on all the bots before landing. > Source/WebCore/ChangeLog:14 > + * platform/chromium/ChromiumDataObject.cpp: Please mention here that this is replacing DataTransferItemListChromium. > Source/WebCore/platform/chromium/ChromiumDataObject.h:59 > + // DataTransferItemList support. > + size_t length() const; Should ChromiumDataObject implement DataTransferItemList? > Source/WebCore/platform/chromium/ChromiumDataObjectItem.h:49 > +class ChromiumDataObjectItem : public RefCounted<ChromiumDataObjectItem> { Should ChromiumDataObjectItem implement DataTransferItem? (In reply to comment #2) > (From update of attachment 134191 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=134191&action=review > > Looks like your patch needs to be rebased. Please make sure to have a green ews run on all the bots before landing. > > > Source/WebCore/ChangeLog:14 > > + * platform/chromium/ChromiumDataObject.cpp: > > Please mention here that this is replacing DataTransferItemListChromium. > Done. > > Source/WebCore/platform/chromium/ChromiumDataObject.h:59 > > + // DataTransferItemList support. > > + size_t length() const; > > Should ChromiumDataObject implement DataTransferItemList? > > > Source/WebCore/platform/chromium/ChromiumDataObjectItem.h:49 > > +class ChromiumDataObjectItem : public RefCounted<ChromiumDataObjectItem> { > > Should ChromiumDataObjectItem implement DataTransferItem? We don't implement these interfaces because the signatures of some functions are a little different, plus we avoid virtual dispatch. Created attachment 134352 [details]
Patch
Committed r112448: <http://trac.webkit.org/changeset/112448> |