Bug 82407

Summary: [chromium] Merge ChromiumDataObject and DataTransferItemListChromium.
Product: WebKit Reporter: Daniel Cheng <dcheng>
Component: New BugsAssignee: Daniel Cheng <dcheng>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Daniel Cheng
Reported 2012-03-27 18:27:27 PDT
[chromium] Merge ChromiumDataObject and DataTransferItemListChromium.
Attachments
Patch (57.57 KB, patch)
2012-03-27 18:31 PDT, Daniel Cheng 		no flags
DetailsFormatted DiffDiff
Patch (57.65 KB, patch)
2012-03-28 11:37 PDT, Daniel Cheng 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Daniel Cheng
Comment 1 2012-03-27 18:31:50 PDT
Created attachment 134191 [details] Patch
Tony Chang
Comment 2 2012-03-28 09:47:44 PDT
Comment on attachment 134191 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=134191&action=review Looks like your patch needs to be rebased. Please make sure to have a green ews run on all the bots before landing. > Source/WebCore/ChangeLog:14 > + * platform/chromium/ChromiumDataObject.cpp: Please mention here that this is replacing DataTransferItemListChromium. > Source/WebCore/platform/chromium/ChromiumDataObject.h:59 > + // DataTransferItemList support. > + size_t length() const; Should ChromiumDataObject implement DataTransferItemList? > Source/WebCore/platform/chromium/ChromiumDataObjectItem.h:49 > +class ChromiumDataObjectItem : public RefCounted<ChromiumDataObjectItem> { Should ChromiumDataObjectItem implement DataTransferItem?
Daniel Cheng
Comment 3 2012-03-28 11:34:10 PDT
(In reply to comment #2) > (From update of attachment 134191 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=134191&action=review > > Looks like your patch needs to be rebased. Please make sure to have a green ews run on all the bots before landing. > > > Source/WebCore/ChangeLog:14 > > + * platform/chromium/ChromiumDataObject.cpp: > > Please mention here that this is replacing DataTransferItemListChromium. > Done. > > Source/WebCore/platform/chromium/ChromiumDataObject.h:59 > > + // DataTransferItemList support. > > + size_t length() const; > > Should ChromiumDataObject implement DataTransferItemList? > > > Source/WebCore/platform/chromium/ChromiumDataObjectItem.h:49 > > +class ChromiumDataObjectItem : public RefCounted<ChromiumDataObjectItem> { > > Should ChromiumDataObjectItem implement DataTransferItem? We don't implement these interfaces because the signatures of some functions are a little different, plus we avoid virtual dispatch.
Daniel Cheng
Comment 4 2012-03-28 11:37:05 PDT
Created attachment 134352 [details] Patch
Daniel Cheng
Comment 5 2012-03-28 15:03:51 PDT
Committed r112448: <http://trac.webkit.org/changeset/112448>
Note You need to log in before you can comment on or make changes to this bug.