| Summary: | Add missing methods and operators to FractionalLayoutUnit | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Emil A Eklund <eae> | ||||||||||
| Component: | Layout and Rendering | Assignee: | Emil A Eklund <eae> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | dglazkov, eric, gustavo, leviw, lforschler, pnormand, webkit.review.bot, xan.lopez | ||||||||||
| Priority: | P2 | ||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Bug Depends on: | |||||||||||||
| Bug Blocks: | 60318 | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Emil A Eklund
2012-03-27 17:37:26 PDT
Created attachment 134304 [details]
Patch
Attachment 134304 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/platform/FractionalLayoutUnit.h:82: wtf_ceil is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Total errors found: 1 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 134304 [details] Patch Attachment 134304 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/12153242 Comment on attachment 134304 [details] Patch Attachment 134304 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/12153246 Comment on attachment 134304 [details] Patch Attachment 134304 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/12159101 Created attachment 134356 [details]
Patch
Attachment 134356 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/platform/FractionalLayoutUnit.h:81: wtf_ceil is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Total errors found: 1 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 134356 [details] Patch Attachment 134356 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/12152338 Comment on attachment 134356 [details] Patch Attachment 134356 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/12152353 Comment on attachment 134356 [details] Patch Attachment 134356 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/12153413 Argh, sorry about all the spam, please ignore this bug for now. Comment on attachment 134356 [details] Patch Attachment 134356 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/12156290 Comment on attachment 134356 [details] Patch Attachment 134356 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12152387 Created attachment 135957 [details]
Patch
Attachment 135957 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/platform/FractionalLayoutUnit.h:81: wtf_ceil is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Total errors found: 1 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 135957 [details] Patch Attachment 135957 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/12337629 Comment on attachment 135957 [details] Patch Attachment 135957 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/12336709 Unhappy ewses. Comment on attachment 135957 [details] Patch Attachment 135957 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/12343011 Created attachment 136265 [details]
Patch
Attachment 136265 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/platform/FractionalLayoutUnit.h:81: wtf_ceil is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Total errors found: 1 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
The style ews failure is expected (wtf_ceil) but the others seem happy now at least. Can haz review? Comment on attachment 136265 [details]
Patch
OK.
Comment on attachment 136265 [details] Patch Clearing flags on attachment: 136265 Committed r113730: <http://trac.webkit.org/changeset/113730> All reviewed patches have been landed. Closing bug. This check in causes a 20% decrease in performance for the Mac Lion dromeo test http://webkit-perf.appspot.com/graph.html#tests=[[33030,2001,32196]]&sel=none&displayrange=7&datatype=running (In reply to comment #27) > This check in causes a 20% decrease in performance for the Mac Lion dromeo test > http://webkit-perf.appspot.com/graph.html#tests=[[33030,2001,32196]]&sel=none&displayrange=7&datatype=running I don't think this is the cause of that regression... None of this code is in use yet. Ah, the test results are not atomic. The regression happened somewhere between 113608 and 113730. (In reply to comment #29) > Ah, the test results are not atomic. The regression happened somewhere between 113608 and 113730. That'd explain it :) Here's a handy link: http://trac.webkit.org/log/?action=stop_on_copy&mode=stop_on_copy&rev=113730&stop_rev=113608&limit=200 |