Bug 82397

Summary: Simplify CSSPropertyBorderSpacing parsing.
Product: WebKit Reporter: Alexis Menard (darktears) <menard>
Component: CSSAssignee: Alexis Menard (darktears) <menard>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, kling, koivisto, macpherson, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Alexis Menard (darktears)
Reported 2012-03-27 16:46:45 PDT
Share code with CSSPropertyLonghand when parsing CSSPropertyBorderSpacing.
Attachments
Patch (2.19 KB, patch)
2012-03-27 16:48 PDT, Alexis Menard (darktears) 		no flags
DetailsFormatted DiffDiff
Patch (2.18 KB, patch)
2012-03-27 17:01 PDT, Alexis Menard (darktears) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alexis Menard (darktears)
Comment 1 2012-03-27 16:48:56 PDT
Created attachment 134167 [details] Patch
Benjamin Poulain
Comment 2 2012-03-27 16:52:09 PDT
Comment on attachment 134167 [details] Patch I don't get it, why not pass the property directly?: if (!parseValue(CSSPropertyWebkitBorderHorizontalSpacing, important))
Alexis Menard (darktears)
Comment 3 2012-03-27 16:54:07 PDT
(In reply to comment #2) > (From update of attachment 134167 [details]) > I don't get it, why not pass the property directly?: > if (!parseValue(CSSPropertyWebkitBorderHorizontalSpacing, important)) Could be. Let me update the bug name then.
Alexis Menard (darktears)
Comment 4 2012-03-27 17:01:39 PDT
Created attachment 134172 [details] Patch
Benjamin Poulain
Comment 5 2012-03-27 17:05:36 PDT
Comment on attachment 134172 [details] Patch Looks good. The CSSPropertyID looks much better than properties[x]
WebKit Review Bot
Comment 6 2012-03-27 17:27:44 PDT
Comment on attachment 134172 [details] Patch Clearing flags on attachment: 134172 Committed r112341: <http://trac.webkit.org/changeset/112341>
WebKit Review Bot
Comment 7 2012-03-27 17:27:57 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.