Bug 82388

Summary: kill-old-processes doesn't do anything on linux
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: New BugsAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, jesus, mrobinson, ossy, pnormand, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
proposed fix for Qt bots
none
proposed fix for Qt bots
none
proposed fix for Qt bots
none
better fix for Qt bots none

Ryosuke Niwa
Reported 2012-03-27 15:34:11 PDT
kill-old-processes doesn't do anything on linux
Attachments
Patch (2.19 KB, patch)
2012-03-27 15:36 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
proposed fix for Qt bots (1.55 KB, patch)
2012-03-27 22:46 PDT, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
proposed fix for Qt bots (1.55 KB, patch)
2012-03-27 22:48 PDT, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
proposed fix for Qt bots (1.79 KB, patch)
2012-03-28 00:00 PDT, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
better fix for Qt bots (1.79 KB, patch)
2012-03-28 00:09 PDT, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2012-03-27 15:36:04 PDT
Created attachment 134149 [details] Patch
Ryosuke Niwa
Comment 2 2012-03-27 15:42:40 PDT
Ossy: Tony told me that this may cause problems for Qt bots since you guys run multiple builders simultaneously on the same machine. Is that still the case?
Csaba Osztrogonác
Comment 3 2012-03-27 22:22:34 PDT
(In reply to comment #2) > Ossy: > > Tony told me that this may cause problems for Qt bots since you guys run multiple builders simultaneously on the same machine. Is that still the case? Yes, we still run multiple builders on the same machine. Additionally sometimes we try something on the bots. So this patch would be overkiller for our bots. :(
Csaba Osztrogonác
Comment 4 2012-03-27 22:46:06 PDT
Created attachment 134220 [details] proposed fix for Qt bots We don't need kill old processes for the Qt bots, so the simplest solution is that we don't run it. :) This patch should be landed and master should be reconfigured before the other patch landed from this bug.
Csaba Osztrogonác
Comment 5 2012-03-27 22:46:34 PDT
Comment on attachment 134220 [details] proposed fix for Qt bots ooops, typo
Csaba Osztrogonác
Comment 6 2012-03-27 22:48:09 PDT
Created attachment 134221 [details] proposed fix for Qt bots s/==/!=/g - done ;)
Csaba Osztrogonác
Comment 7 2012-03-27 23:43:41 PDT
Comment on attachment 134221 [details] proposed fix for Qt bots Clearing flags on attachment: 134221 Committed r112367: <http://trac.webkit.org/changeset/112367>
Csaba Osztrogonác
Comment 8 2012-03-28 00:00:25 PDT
Created attachment 134224 [details] proposed fix for Qt bots Unfortunately the previous one didn't work, because platform were qt-4.8, qt-5.0-wk1, ... here
Csaba Osztrogonác
Comment 9 2012-03-28 00:09:00 PDT
Created attachment 134225 [details] better fix for Qt bots
Csaba Osztrogonác
Comment 10 2012-03-28 01:16:37 PDT
Comment on attachment 134225 [details] better fix for Qt bots Clearing flags on attachment: 134225 Committed r112371: <http://trac.webkit.org/changeset/112371>
Csaba Osztrogonác
Comment 11 2012-03-28 01:20:52 PDT
(In reply to comment #10) > (From update of attachment 134225 [details]) > Clearing flags on attachment: 134225 > > Committed r112371: <http://trac.webkit.org/changeset/112371> Qt bots don't run kill-old-processes anymore, so it's safe to land the original patch now.
WebKit Review Bot
Comment 12 2012-03-28 01:26:55 PDT
Comment on attachment 134149 [details] Patch Clearing flags on attachment: 134149 Committed r112373: <http://trac.webkit.org/changeset/112373>
WebKit Review Bot
Comment 13 2012-03-28 01:27:00 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.