| Summary: | kill-old-processes doesn't do anything on linux | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> | ||||||||||||
| Component: | New Bugs | Assignee: | Ryosuke Niwa <rniwa> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | gyuyoung.kim, jesus, mrobinson, ossy, pnormand, tony, webkit.review.bot | ||||||||||||
| Priority: | P2 | ||||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Ryosuke Niwa
2012-03-27 15:34:11 PDT
Created attachment 134149 [details]
Patch
Ossy: Tony told me that this may cause problems for Qt bots since you guys run multiple builders simultaneously on the same machine. Is that still the case? (In reply to comment #2) > Ossy: > > Tony told me that this may cause problems for Qt bots since you guys run multiple builders simultaneously on the same machine. Is that still the case? Yes, we still run multiple builders on the same machine. Additionally sometimes we try something on the bots. So this patch would be overkiller for our bots. :( Created attachment 134220 [details]
proposed fix for Qt bots
We don't need kill old processes for the Qt bots,
so the simplest solution is that we don't run it. :)
This patch should be landed and master should be
reconfigured before the other patch landed from this bug.
Comment on attachment 134220 [details]
proposed fix for Qt bots
ooops, typo
Created attachment 134221 [details]
proposed fix for Qt bots
s/==/!=/g - done ;)
Comment on attachment 134221 [details] proposed fix for Qt bots Clearing flags on attachment: 134221 Committed r112367: <http://trac.webkit.org/changeset/112367> Created attachment 134224 [details]
proposed fix for Qt bots
Unfortunately the previous one didn't work,
because platform were qt-4.8, qt-5.0-wk1, ... here
Created attachment 134225 [details]
better fix for Qt bots
Comment on attachment 134225 [details] better fix for Qt bots Clearing flags on attachment: 134225 Committed r112371: <http://trac.webkit.org/changeset/112371> (In reply to comment #10) > (From update of attachment 134225 [details]) > Clearing flags on attachment: 134225 > > Committed r112371: <http://trac.webkit.org/changeset/112371> Qt bots don't run kill-old-processes anymore, so it's safe to land the original patch now. Comment on attachment 134149 [details] Patch Clearing flags on attachment: 134149 Committed r112373: <http://trac.webkit.org/changeset/112373> All reviewed patches have been landed. Closing bug. |