Bug 82387

Summary: Plug-ins using the Core Animation drawing model should work when hosting the layer tree in the window server
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: gustavo, menard, webkit.review.bot, xan.lopez, zoltan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch sam: review+

Anders Carlsson
Reported 2012-03-27 15:19:56 PDT
Plug-ins using the Core Animation drawing model should work when hosting the layer tree in the window server
Attachments
Patch (26.67 KB, patch)
2012-03-27 15:34 PDT, Anders Carlsson 		no flags
DetailsFormatted DiffDiff
Patch (26.76 KB, patch)
2012-03-27 15:47 PDT, Anders Carlsson 		no flags
DetailsFormatted DiffDiff
Patch (26.67 KB, patch)
2012-03-27 15:55 PDT, Anders Carlsson 		sam: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2012-03-27 15:34:09 PDT
Created attachment 134148 [details] Patch
Early Warning System Bot
Comment 2 2012-03-27 15:43:42 PDT
Comment on attachment 134148 [details] Patch Attachment 134148 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/12147744
Gustavo Noronha (kov)
Comment 3 2012-03-27 15:44:24 PDT
Comment on attachment 134148 [details] Patch Attachment 134148 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/12142750
Sam Weinig
Comment 4 2012-03-27 15:46:30 PDT
Comment on attachment 134148 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=134148&action=review > Source/WebKit2/PluginProcess/PluginControllerProxy.messages.in:103 > + # Sent when the containing window's layer hosting mode changes > + SetLayerHostingMode(uint32_t layerHostingMode) Do we want to call this LayerHostingModeChanged to match the message above? > Source/WebKit2/WebProcess/Plugins/Plugin.h:29 > +#include "LayerHostingContext.h" Is this header included on all platforms? Or should it be in an #ifdef?
Anders Carlsson
Comment 5 2012-03-27 15:47:39 PDT
Created attachment 134152 [details] Patch
Gustavo Noronha (kov)
Comment 6 2012-03-27 15:53:30 PDT
Comment on attachment 134152 [details] Patch Attachment 134152 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/12140789
Anders Carlsson
Comment 7 2012-03-27 15:55:40 PDT
(In reply to comment #4) > (From update of attachment 134148 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=134148&action=review > > > Source/WebKit2/PluginProcess/PluginControllerProxy.messages.in:103 > > + # Sent when the containing window's layer hosting mode changes > > + SetLayerHostingMode(uint32_t layerHostingMode) > > Do we want to call this LayerHostingModeChanged to match the message above? > Nah, it's really a setter. > > Source/WebKit2/WebProcess/Plugins/Plugin.h:29 > > +#include "LayerHostingContext.h" > > Is this header included on all platforms? Or should it be in an #ifdef? I'll add #ifdefs.
Anders Carlsson
Comment 8 2012-03-27 15:55:50 PDT
Created attachment 134154 [details] Patch
Anders Carlsson
Comment 9 2012-03-27 17:17:09 PDT
Committed r112338: <http://trac.webkit.org/changeset/112338>
Note You need to log in before you can comment on or make changes to this bug.