|Summary:||[chromium] Filter context vs. webkit_unit_tests|
|Product:||WebKit||Reporter:||Stephen White <senorblanco>|
|Component:||Platform||Assignee:||Stephen White <senorblanco>|
|Severity:||Normal||CC:||cc-bugs, danakj, jamesr, webkit.review.bot|
|Version:||528+ (Nightly build)|
Description Stephen White 2012-03-27 09:22:11 PDT
Fix failures in webkit_unit_tests and re-enable CCLayerTreeHostTestSetSingleLostContext.runMultiThread.
Comment 2 Stephen White 2012-03-27 09:33:34 PDT
These problems occur because the request for filter contexts is left open, and subsequent tests actually attempt to allocate a real GL context, which asserts because SetGLImplementation() hasn't been called. For now, I'm just cancelling the request for filter contexts after the occlusion tests run. A longer-term solution might be to mock out the GL context (either as the compositor context is mocked in the Web.*Client, or by calling SetGLImplementation(kGLImplementationMockGL), but since this is all probably going to change once we can create contexts in the impl thread, this will keep things running for now.
Comment 3 James Robinson 2012-03-27 09:59:37 PDT
Comment on attachment 134084 [details] Patch Seems reasonable