Bug 82345

Summary: Frame flattening: childframe in FrameView::layout() needs protector.
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Minor CC: koivisto, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

zalan
Reported 2012-03-27 08:55:54 PDT
In case of frame flattening, when the child frame is re-starting the layout from the topmost parent, childframe needs RefPtr<FrameView> protector(this); so that it won't get destroyed by a recalcStyle() call in a parent layout(). fix: move RefPtr<FrameView> protector(this); in FrameView::layout() a few lines up, before the frame flattening re-start.
Attachments
Patch (2.14 KB, patch)
2012-03-27 10:02 PDT, zalan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2012-03-27 10:02:39 PDT
Created attachment 134088 [details] Patch
WebKit Review Bot
Comment 2 2012-03-27 11:01:07 PDT
Comment on attachment 134088 [details] Patch Clearing flags on attachment: 134088 Committed r112283: <http://trac.webkit.org/changeset/112283>
WebKit Review Bot
Comment 3 2012-03-27 11:01:11 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.