Bug 82342

Summary: Fix build break when CONTEXT_MENUS is disabled
Product: WebKit Reporter: Mariusz Grzegorczyk <mariusz.g>
Component: WebKit Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: g.czajkowski, gustavo, gyuyoung.kim, mrobinson, pnormand, rakuco, svillar, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch fixing GTK build break when CONTEXT_MENUS is disabled
gyuyoung.kim: commit-queue-
patch fixing GTK/EFL build break when CONTEXT_MENUS is disabled
kling: review+
patch fixing GTK/EFL build break when CONTEXT_MENUS is disabled
none
patch fixing GTK/EFL build break when CONTEXT_MENUS is disabled none

Description Mariusz Grzegorczyk 2012-03-27 08:20:25 PDT
When CONTEXT_MENUS macro is disabled build break occurs with following error:
../../Source/WebKit/gtk/webkit/webkitwebview.cpp: In function 'gboolean webkit_web_view_forward_context_menu_event(WebKitWebView*, const WebCore::PlatformMouseEvent&)':
../../Source/WebKit/gtk/webkit/webkitwebview.cpp:325:11: error: 'class WebCore::Page has no member named 'contextMenuController'
../../Source/WebKit/gtk/webkit/webkitwebview.cpp:355:55: error: 'class WebCore::EventHandler has no member named 'sendContextMenuEvent'
../../Source/WebKit/gtk/webkit/webkitwebview.cpp:362:47: error: 'class WebCore::Page has no member named 'contextMenuController'
Comment 1 Mariusz Grzegorczyk 2012-03-28 02:33:21 PDT
Created attachment 134243 [details]
patch fixing GTK build break when CONTEXT_MENUS is disabled
Comment 2 Gyuyoung Kim 2012-03-28 02:44:27 PDT
Comment on attachment 134243 [details]
patch fixing GTK build break when CONTEXT_MENUS is disabled

Attachment 134243 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/12151084
Comment 3 Mariusz Grzegorczyk 2012-03-28 05:32:19 PDT
Created attachment 134273 [details]
patch fixing GTK/EFL build break when CONTEXT_MENUS is disabled
Comment 4 Grzegorz Czajkowski 2012-04-02 03:51:59 PDT
LGTM.
CONTEXT_MENUS macro is disabled for WebKit2 EFL port. This patch is a first step to allow build WebKit2-EFL.
It's a base patch which allows further modifications related to specific components for example, WebKit2 and WebKtit-EFL. 

Could you review it, please?
Thanks
Comment 5 Andreas Kling 2012-04-02 04:55:25 PDT
Comment on attachment 134273 [details]
patch fixing GTK/EFL build break when CONTEXT_MENUS is disabled

View in context: https://bugs.webkit.org/attachment.cgi?id=134273&action=review

Sure, r=me.

> Source/WebCore/ChangeLog:3
> +        Fix build break when CONTEXT_MENUS is disabled.

Missing bug number here.
Comment 6 Mariusz Grzegorczyk 2012-04-02 06:26:45 PDT
Created attachment 135085 [details]
patch fixing GTK/EFL build break when CONTEXT_MENUS is disabled

Rebased, added bug number in changelog.
Comment 7 Mariusz Grzegorczyk 2012-04-02 06:32:39 PDT
Created attachment 135086 [details]
patch fixing GTK/EFL build break when CONTEXT_MENUS is disabled
Comment 8 WebKit Review Bot 2012-04-02 06:33:19 PDT
Comment on attachment 135086 [details]
patch fixing GTK/EFL build break when CONTEXT_MENUS is disabled

Rejecting attachment 135086 [details] from commit-queue.

mariusz.g@samsung.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.
Comment 9 WebKit Review Bot 2012-04-04 00:31:09 PDT
Comment on attachment 135086 [details]
patch fixing GTK/EFL build break when CONTEXT_MENUS is disabled

Clearing flags on attachment: 135086

Committed r113147: <http://trac.webkit.org/changeset/113147>
Comment 10 WebKit Review Bot 2012-04-04 00:31:15 PDT
All reviewed patches have been landed.  Closing bug.