Summary: | [GTK] Add --skipped command line option to Tools/Scripts/run-gtk-tests | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> | ||||
Component: | Tools / Tests | Assignee: | Carlos Garcia Campos <cgarcia> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | eric, pnormand | ||||
Priority: | P2 | Keywords: | Gtk | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | Linux | ||||||
Bug Depends on: | 82333 | ||||||
Bug Blocks: | |||||||
Attachments: |
|
Description
Carlos Garcia Campos
2012-03-27 08:00:13 PDT
Created attachment 134065 [details]
Patch
Comment on attachment 134065 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=134065&action=review > Tools/Scripts/run-gtk-tests:216 > + # By default skipped test are skipped, > + # run them only when there are specific > + # test cases failing. Super nit: This comment could probably be one line. > Tools/Scripts/run-gtk-tests:296 > + help='Specifies how to treat the Skipped tests') Nit: Skipped -> skipped (In reply to comment #2) > (From update of attachment 134065 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=134065&action=review > > > Tools/Scripts/run-gtk-tests:216 > > + # By default skipped test are skipped, > > + # run them only when there are specific > > + # test cases failing. > > Super nit: This comment could probably be one line. Ok :-) > > Tools/Scripts/run-gtk-tests:296 > > + help='Specifies how to treat the Skipped tests') > > Nit: Skipped -> skipped Sure, thanks! Attachment 134065 [details] was posted by a committer and has review+, assigning to Carlos Garcia Campos for commit.
Committed r112406: <http://trac.webkit.org/changeset/112406> |