| Summary: | Construct CSSCharsetRule on CSSOM API access only | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Antti Koivisto <koivisto> | ||||
| Component: | CSS | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | kling, macpherson, menard, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 77745 | ||||||
| Attachments: |
|
||||||
|
Description
Antti Koivisto
2012-03-27 06:33:44 PDT
Created attachment 134078 [details]
patch
Attachment 134078 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/css/CSSStyleSheet.cpp:134: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5]
Source/WebCore/css/CSSStyleSheet.cpp:202: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5]
Source/WebCore/css/CSSStyleSheet.cpp:210: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5]
Source/WebCore/css/CSSStyleSheet.cpp:266: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5]
Total errors found: 4 in 6 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 134078 [details]
patch
r=me
You might wanna herp where stylebot indicates that you have derped.
|