Bug 82322

Summary: Web Inspector: startEditing should remove tabIndex attribute from the element if it was not set before.
Product: WebKit Reporter: Vsevolod Vlasov <vsevik>
Component: Web Inspector (Deprecated)Assignee: Vsevolod Vlasov <vsevik>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch pfeldman: review+

Vsevolod Vlasov
Reported 2012-03-27 04:51:23 PDT
startEditing should remove tabIndex attribute from the element if it was not set before.
Attachments
Patch (2.00 KB, patch)
2012-03-27 04:54 PDT, Vsevolod Vlasov 		no flags
DetailsFormatted DiffDiff
Patch (2.01 KB, patch)
2012-03-27 04:54 PDT, Vsevolod Vlasov 		pfeldman: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Vsevolod Vlasov
Comment 1 2012-03-27 04:54:01 PDT
Created attachment 134027 [details] Patch
Vsevolod Vlasov
Comment 2 2012-03-27 04:54:52 PDT
Created attachment 134028 [details] Patch
Pavel Feldman
Comment 3 2012-03-27 05:14:42 PDT
Comment on attachment 134028 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=134028&action=review > Source/WebCore/inspector/front-end/UIUtils.js:284 > + if (typeof(oldTabIndex) !== "number" || oldTabIndex < 0) typeof oldTabIndex !== "number" or use isNaN.
Vsevolod Vlasov
Comment 4 2012-03-27 05:32:25 PDT
Committed r112257: <http://trac.webkit.org/changeset/112257>
Note You need to log in before you can comment on or make changes to this bug.