Bug 82318

Summary: Web Inspector: dispatch breakpoint-added and breakpoint-removed events on UISourceCode.
Product: WebKit Reporter: Pavel Podivilov <podivilov>
Component: Web Inspector (Deprecated)Assignee: Pavel Podivilov <podivilov>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, vsevik, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 82224    
Attachments:
Description Flags
Patch vsevik: review+

Description Pavel Podivilov 2012-03-27 03:43:04 PDT
Web Inspector: dispatch breakpoint-added and breakpoint-removed events on UISourceCode.

See bug 82224 for rationale.
Comment 1 Pavel Podivilov 2012-03-27 03:44:37 PDT
Created attachment 134015 [details]
Patch
Comment 2 Vsevolod Vlasov 2012-03-27 04:17:21 PDT
Comment on attachment 134015 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=134015&action=review

> Source/WebCore/inspector/front-end/ScriptsPanel.js:285
> +    _addBreakpointListeners: function(uiSourceCode)

Please add type annotations.

> Source/WebCore/inspector/front-end/ScriptsPanel.js:291
> +    _removeBreakpointListeners: function(uiSourceCode)

ditto
Comment 3 Pavel Podivilov 2012-03-27 07:57:54 PDT
Committed r112266: <http://trac.webkit.org/changeset/112266>