Bug 82290 – test-webkitpy: prepare for better test run output

• Component: New Bugs
• Status: RESOLVED FIXED

[Dirk Pranke]

test-webkitpy: prepare for better test run output

[Dirk Pranke]

Created attachment 133967 [details]
Patch

[Dirk Pranke]

This change is a prelude to me landing logging changes for per-test timing information and a MeteredStream-style form of output. It will also be the basis for implementing parallel testing, if we decide that's worth it.

[Adam Barth]

Comment on attachment 133967 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=133967&action=review

> Tools/Scripts/webkitpy/test/runner.py:68
> +            # FIXME: it's kinda lame that we re-load the test suites for each
> +            # test, and this may slow things down, but this makes implementing
> +            # the logging easy and will also allow us to parallelize nicely.

Have you measured how much this slows us down?

[Dirk Pranke]

(In reply to comment #3)
> (From update of attachment 133967 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=133967&action=review
> 
> > Tools/Scripts/webkitpy/test/runner.py:68
> > +            # FIXME: it's kinda lame that we re-load the test suites for each
> > +            # test, and this may slow things down, but this makes implementing
> > +            # the logging easy and will also allow us to parallelize nicely.
> 
> Have you measured how much this slows us down?

A couple of unscientific tests seem to point to about a half-second slowdown on my mac pro (18.2 seconds -> 18.7). I'm actually a bit surprised that it's noticeable at all, so I'll have to dig into it further to see what the cause of this is, but I think this is well within the noise for now.

[Dirk Pranke]

Also, I notice that this patch doesn't have the unit tests I wrote in it ... will upload those as well and then land.

[Dirk Pranke]

Created attachment 134110 [details]
Patch

[Dirk Pranke]

Committed r112298: <http://trac.webkit.org/changeset/112298>

[Eric Seidel (no email)]

Comment on attachment 134110 [details]
Patch

Cleared review? from attachment 134110 [details] so that this bug does not appear in http://webkit.org/pending-review.  If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).