Bug 82283

Summary: ImageLoader::m_firedLoadEvent is a confusing name
Product: WebKit Reporter: WebKit Review Bot <webkit.review.bot>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, ap, haraken, japhet, tkent
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description WebKit Review Bot 2012-03-26 18:39:01 PDT 
Clean up ImageLoader::m_firedLoadEvent
Requested by abarth on #webkit.
Comment 1 Adam Barth 2012-03-26 22:56:15 PDT 
Created attachment 133980 [details]
Patch
Comment 2 Kentaro Hara 2012-03-26 23:04:03 PDT 
Comment on attachment 133980 [details]
Patch

OK
Comment 3 WebKit Review Bot 2012-03-27 00:21:55 PDT 
Comment on attachment 133980 [details]
Patch

Clearing flags on attachment: 133980

Committed r112215: <http://trac.webkit.org/changeset/112215>
Comment 4 WebKit Review Bot 2012-03-27 00:21:59 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Alexey Proskuryakov 2012-03-27 14:21:44 PDT 
I had an abandoned patch for the same some time ago, <https://bugs.webkit.org/attachment.cgi?id=76669&action=review>. It got stuck because it was trying to do too much at once.

Now that you're at it, perhaps you'll have the interest to finish the job, and make script elements sensible, too?
Comment 6 Adam Barth 2012-03-27 14:30:30 PDT 
> Now that you're at it, perhaps you'll have the interest to finish the job, and make script elements sensible, too?

Yeah, I saw the script element one in my grep as well.  I'm happy to change that one too.