Bug 82282

Summary: Clean up Document::canNavigate
Product: WebKit Reporter: WebKit Review Bot <webkit.review.bot>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

WebKit Review Bot
Reported 2012-03-26 18:38:46 PDT
Clean up Document::canNavigate Requested by abarth on #webkit.
Attachments
Patch (8.00 KB, patch)
2012-04-01 18:01 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch (12.70 KB, patch)
2012-04-01 19:01 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch for landing (12.71 KB, patch)
2012-04-01 19:05 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2012-04-01 18:01:57 PDT
Created attachment 135016 [details] Patch
Adam Barth
Comment 2 2012-04-01 19:01:22 PDT
Created attachment 135018 [details] Patch
Eric Seidel (no email)
Comment 3 2012-04-01 19:03:54 PDT
Comment on attachment 135018 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=135018&action=review OK. Looks like there is still a little work here. > Source/WebCore/dom/Document.cpp:383 > + // FIXME: should we print to the console of the activeFrame as well? This fixme seems in the wrong place now.
Adam Barth
Comment 4 2012-04-01 19:05:50 PDT
Created attachment 135019 [details] Patch for landing
WebKit Review Bot
Comment 5 2012-04-01 19:43:36 PDT
Comment on attachment 135019 [details] Patch for landing Clearing flags on attachment: 135019 Committed r112825: <http://trac.webkit.org/changeset/112825>
WebKit Review Bot
Comment 6 2012-04-01 19:43:41 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.