| Summary: | Speech* files should be moved from page/ to Modules/speech/ | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Hajime Morrita <morrita> | ||||
| Component: | Page Loading | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | NEW --- | ||||||
| Severity: | Normal | CC: | abarth, gyuyoung.kim, rakuco, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 79327 | ||||||
| Attachments: |
|
||||||
|
Description
Hajime Morrita
2012-03-26 17:56:20 PDT
Created attachment 151166 [details]
Working in Progress - for chromium, gtk and efl
Hello Hajime,
Do you think this bug is still valid ? If so, I make a patch for chromium, gtk, and efl in order to help you fix this bug. If you don't have time, I'm able to submit a patch for all ports.
Comment on attachment 151166 [details] Working in Progress - for chromium, gtk and efl Attachment 151166 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/13166047 Comment on attachment 151166 [details] Working in Progress - for chromium, gtk and efl Attachment 151166 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/13160244 Comment on attachment 151166 [details] Working in Progress - for chromium, gtk and efl Attachment 151166 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/13151977 Comment on attachment 151166 [details] Working in Progress - for chromium, gtk and efl Attachment 151166 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/13157660 Comment on attachment 151166 [details]
Working in Progress - for chromium, gtk and efl
Isn't there an include from HTMLInputElement to speech?
I haven't fully chased this down, but there are at least some mentions of speech in HTMLInputElement: http://trac.webkit.org/browser/trunk/Source/WebCore/html/HTMLInputElement.cpp#L658 To my quick searching, below files are related to INPUT_SPEECH macro. - css/CSSPrimitiveValueMappings.h - dom/Element.h - html/TextFieldInputType.h - html/HTMLInputElement.h - html/HTMLInputElement.cpp - html/shadow/TextControlInnerElements.h - html/InputType.h - html/TextFieldInputType.cpp I'm not sure whether page/SpeechInputXXX files can be moved to Modules/speech. It seems to me SpeechInput is used more than other modules out of Modules directory. Adam, I'd like to know how do you think this ? The idea behind Modules is that there shouldn't be any references to things inside the module from things outside the module (except perhaps from bindings or the inspector). I suspect that this speech code is too tightly coupled to the input element to be a separate module at this point. (In reply to comment #9) > The idea behind Modules is that there shouldn't be any references to things inside the module from things outside the module (except perhaps from bindings or the inspector). I suspect that this speech code is too tightly coupled to the input element to be a separate module at this point. BTW, it looks that files outside the modules only use them to support input speech button. In this case, can't we move it to Modules/speech ? If so, I think this bug needs to be closed. |