Bug 82263

Summary: [chromium] Add virtual test suite for threaded compositing
Product: WebKit Reporter: Adrienne Walker <enne>
Component: New BugsAssignee: Adrienne Walker <enne>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dpranke, enne, jamesr, ojan, vangelis
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 82405, 82486    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Only enable for compositing/visibility jamesr: review+

Adrienne Walker
Reported 2012-03-26 17:00:58 PDT
[chromium] Add virtual test suite for threaded compositing
Attachments
Patch (17.52 KB, patch)
2012-03-26 17:28 PDT, Adrienne Walker 		no flags
DetailsFormatted DiffDiff
Only enable for compositing/visibility (2.17 KB, patch)
2012-04-06 13:35 PDT, Adrienne Walker 		jamesr: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adrienne Walker
Comment 1 2012-03-26 17:28:43 PDT
Created attachment 133937 [details] Patch
James Robinson
Comment 2 2012-03-26 17:38:33 PDT
Hm, it passes every test that passes in the non-threaded mode? Color me pleasantly surprised!
Adrienne Walker
Comment 3 2012-03-26 17:42:49 PDT
(In reply to comment #2) > Hm, it passes every test that passes in the non-threaded mode? Color me pleasantly surprised! The joke's on you. DRT doesn't properly obey the --enable-threaded-compositing flag. :(
Dirk Pranke
Comment 4 2012-03-26 17:43:57 PDT
I think it'll probably take about one more test suite to convince me that we need to support test expectation inheritance as well (if even that).
Adrienne Walker
Comment 5 2012-04-06 13:35:16 PDT
Created attachment 136057 [details] Only enable for compositing/visibility
James Robinson
Comment 6 2012-04-06 13:41:16 PDT
Comment on attachment 136057 [details] Only enable for compositing/visibility Nice
Dimitri Glazkov (Google)
Comment 7 2012-04-06 13:43:24 PDT
Comment on attachment 136057 [details] Only enable for compositing/visibility Holy crap, this virtual suite stuff is sweet!! Ok, I am done with puns for today.
Adrienne Walker
Comment 8 2012-04-06 18:10:10 PDT
Committed r113529: <http://trac.webkit.org/changeset/113529>
Note You need to log in before you can comment on or make changes to this bug.