Bug 82247 – Find in page overlay and bouncy are not always positioned correctly

• Component: New Bugs
• Status: RESOLVED FIXED

[Anders Carlsson]

Find in page overlay and bouncy are not always positioned correctly

[Anders Carlsson]

Created attachment 133894 [details]
Patch

[Sam Weinig]

Comment on attachment 133894 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=133894&action=review

> Source/WebCore/page/scrolling/ScrollingCoordinator.cpp:227
> +    // Assume that we'll be successful in updating the scroll position.
> +    updateMainFrameScrollPosition(scrollPosition);

Can you explain what happens if that assumption doesn't hold, and how we deal with it?

[Anders Carlsson]

(In reply to comment #2)
> (From update of attachment 133894 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=133894&action=review
> 
> > Source/WebCore/page/scrolling/ScrollingCoordinator.cpp:227
> > +    // Assume that we'll be successful in updating the scroll position.
> > +    updateMainFrameScrollPosition(scrollPosition);
> 
> Can you explain what happens if that assumption doesn't hold, and how we deal with it?

Thinking about it, I'm pretty sure that the assumption will hold so I updated the comment.

[Anders Carlsson]

(In reply to comment #2)
> (From update of attachment 133894 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=133894&action=review
> 
> > Source/WebCore/page/scrolling/ScrollingCoordinator.cpp:227
> > +    // Assume that we'll be successful in updating the scroll position.
> > +    updateMainFrameScrollPosition(scrollPosition);
> 
> Can you explain what happens if that assumption doesn't hold, and how we deal with it?

Thinking about it, I'm pretty sure that the assumption will hold so I updated the comment.

[Anders Carlsson]

Committed r112148: <http://trac.webkit.org/changeset/112148>