Bug 82211

Summary: [BlackBerry] Disable DisallowCType.h usage
Product: WebKit Reporter: Rob Buis <rwlbuis>
Component: WebKit BlackBerryAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Rob Buis 2012-03-26 08:15:09 PDT
We do rely on ctype.h internally, so right now we run into compile problems (Geolocation.cpp).
Comment 1 Ming Xie 2012-03-26 22:03:32 PDT
Created attachment 133973 [details]
Patch
Comment 2 Ming Xie 2012-03-26 22:26:29 PDT
Created attachment 133976 [details]
Patch
Comment 3 Rob Buis 2012-03-27 04:12:20 PDT
Comment on attachment 133976 [details]
Patch

Looks good, thanks! One thing I forgot, there is a similar case in JavaScriptCore, can you do that one too in this patch?
Comment 4 Rob Buis 2012-03-27 07:58:43 PDT
Comment on attachment 133976 [details]
Patch

False alarm, the one in JSC is already fixed.
Comment 5 WebKit Review Bot 2012-03-27 08:44:30 PDT
Comment on attachment 133976 [details]
Patch

Clearing flags on attachment: 133976

Committed r112275: <http://trac.webkit.org/changeset/112275>
Comment 6 WebKit Review Bot 2012-03-27 08:44:35 PDT
All reviewed patches have been landed.  Closing bug.