Bug 82178

Summary: [Qt]WK2] TextureMapperShaderManager should query the program map before creating new shader program instances.
Product: WebKit Reporter: Zeno Albisser <zeno>
Component: WebKit QtAssignee: Zeno Albisser <zeno>
Status: RESOLVED FIXED    
Severity: Normal CC: noam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch for review. none

Zeno Albisser
Reported 2012-03-26 02:16:57 PDT
This bug was introduced by r111986 and the subsequent compile fix r111992. ThextureMapperShaderManager has a map that holds references to all shader programs. If this map does not contain a shader program of the requested type, a new shader program should be created and a reference to it will be stored in the map. If the requested type exists in the map already, a reference to the existing instance shall be returned. See also: https://bugs.webkit.org/show_bug.cgi?id=82049
Attachments
patch for review. (1.62 KB, patch)
2012-03-26 03:15 PDT, Zeno Albisser 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Zeno Albisser
Comment 1 2012-03-26 03:15:54 PDT
Created attachment 133761 [details] patch for review.
Zeno Albisser
Comment 2 2012-03-26 04:17:53 PDT
Comment on attachment 133761 [details] patch for review. Clearing flags on attachment: 133761 Committed r112075: <http://trac.webkit.org/changeset/112075>
Zeno Albisser
Comment 3 2012-03-26 04:18:01 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.